Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14141002: Remove ENABLE_INPUT_TYPE_WEEK compile-time flag. (Closed)

Created:
7 years, 8 months ago by tkent
Modified:
7 years, 8 months ago
Reviewers:
haraken, eseidel
CC:
blink-reviews, haraken, Nate Chapin, abarth-chromium
Visibility:
Public.

Description

Remove ENABLE_INPUT_TYPE_WEEK compile-time flag. This was disabled for Android, and enabled for others. So we keeps the runtime flag WebRuntimeFeatures::enableInputTypeWeek. Android port calls enableInputTypeWeek(false) in Chromium code (See crrev.com/193567) BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148238

Patch Set 1 #

Patch Set 2 : Update html.css #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -44 lines) Patch
M Source/WTF/wtf/FeatureDefines.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/WebCore/css/html.css View 1 4 chunks +0 lines, -4 lines 0 comments Download
M Source/WebCore/html/InputType.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/html/WeekInputType.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebCore/html/WeekInputType.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/LocalizedStrings.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/platform/chromium/LocalizedStringsChromium.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebCore/platform/text/PlatformLocale.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/WebKit/chromium/features.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/WebKit/chromium/tests/WebViewTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/RuntimeEnabledFeatures.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/bindings/v8/RuntimeEnabledFeatures.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tkent
Try bot failures look unrelated to this change.
7 years, 8 months ago (2013-04-11 20:53:36 UTC) #1
eseidel
lgtm Seems reasonable. As with all of these changes, I worry a little that our ...
7 years, 8 months ago (2013-04-11 20:56:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/14141002/6001
7 years, 8 months ago (2013-04-11 20:57:23 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-11 21:20:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/14141002/6001
7 years, 8 months ago (2013-04-11 21:34:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=3490
7 years, 8 months ago (2013-04-11 21:50:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/14141002/6001
7 years, 8 months ago (2013-04-11 22:41:07 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-11 23:19:46 UTC) #8
Message was sent while issue was closed. 
Change committed as 148238

Powered by Google App Engine
This is Rietveld 408576698