Issue 14117004: [Sync] Add support for server-controlled favicon sync limit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14117004: [Sync] Add support for server-controlled favicon sync limit (Closed)

Created:
7 years, 8 months ago by Nicolas Zea

Modified:
7 years, 8 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Add support for server-controlled favicon sync limit This allows us to adjust the number of favicons clients will maintain as we determine how well we handle them. BUG=154886 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195074

Patch Set 1 #

Patch Set 2 : Add proto conversions #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -8 lines)			Patch
M	chrome/browser/sync/glue/favicon_cache.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/session_model_associator.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sync/internal_api/public/util/experiments.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	sync/internal_api/sync_manager_impl.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	sync/protocol/experiments_specifics.proto	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	sync/protocol/proto_value_conversions.cc	View	1	1 chunk	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/14117004/1006

7 years, 8 months ago (2013-04-18 18:20:05 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30285

7 years, 8 months ago (2013-04-18 21:57:46 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/14117004/1006

7 years, 8 months ago (2013-04-18 21:59:04 UTC) #5

Message was sent while issue was closed.

Change committed as 195074

Expand Messages | Collapse Messages