Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 14117004: [Sync] Add support for server-controlled favicon sync limit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add proto conversions Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/protocol/experiments_specifics.proto ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/protocol/proto_value_conversions.cc
diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc
index c83039544f2e3eef3b1b63fa92c5610d29e428e3..cb48346f655de360b98bcf4adf7496f72d3eaec7 100644
--- a/sync/protocol/proto_value_conversions.cc
+++ b/sync/protocol/proto_value_conversions.cc
@@ -332,13 +332,26 @@ base::DictionaryValue* DictionarySpecificsToValue(
return value;
}
+namespace {
+
+DictionaryValue* FaviconSyncFlagsToValue(
+ const sync_pb::FaviconSyncFlags& proto) {
+ base::DictionaryValue* value = new base::DictionaryValue();
+ SET_BOOL(enabled);
+ SET_INT32(favicon_sync_limit);
+ return value;
+}
+
+}
+
base::DictionaryValue* ExperimentsSpecificsToValue(
const sync_pb::ExperimentsSpecifics& proto) {
base::DictionaryValue* value = new base::DictionaryValue();
SET_EXPERIMENT_ENABLED_FIELD(keystore_encryption);
SET_EXPERIMENT_ENABLED_FIELD(history_delete_directives);
SET_EXPERIMENT_ENABLED_FIELD(autofill_culling);
- SET_EXPERIMENT_ENABLED_FIELD(favicon_sync);
+ if (proto.has_favicon_sync())
+ SET(favicon_sync, FaviconSyncFlagsToValue);
return value;
}
« no previous file with comments | « sync/protocol/experiments_specifics.proto ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698