base/strings/string_number_conversions.h - Issue 14109020: HexStringToUInt64 should fail for negative input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_number_conversions.h

Issue 14109020: HexStringToUInt64 should fail for negative input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clamp to closest value in the type range Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/string_number_conversions.h

diff --git a/base/strings/string_number_conversions.h b/base/strings/string_number_conversions.h

index e87c2f5d26f1a12d5de8e9a2357eb58fede8e884..2a757412edf56dc4828f6921bd79abeeb34fc0b2 100644

--- a/base/strings/string_number_conversions.h

+++ b/base/strings/string_number_conversions.h

@@ -50,7 +50,9 @@ BASE_EXPORT std::string DoubleToString(double value);

// Perform a best-effort conversion of the input string to a numeric type,

// setting |*output| to the result of the conversion. Returns true for

// "perfect" conversions; returns false in the following cases:

-// - Overflow/underflow. |*output| will be set to the maximum value supported

+// - Overflow. |*output| will be set to the maximum value supported

+// by the data type.

+// - Underflow. |*output| will be set to the minimum value supported

// by the data type.

// - Trailing characters in the string after parsing the number. |*output|

// will be set to the value of the number that was parsed.

« no previous file with comments | « no previous file | base/strings/string_number_conversions.cc » ('j') | no next file with comments »