base/strings/string_number_conversions.cc - Issue 14109020: HexStringToUInt64 should fail for negative input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_number_conversions.cc

Issue 14109020: HexStringToUInt64 should fail for negative input (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clamp to closest value in the type range Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/string_number_conversions.cc

diff --git a/base/strings/string_number_conversions.cc b/base/strings/string_number_conversions.cc

index fadc81a186f6631a5e5226e49a1e11b969ec2f70..c9b11156ff095e8716c15370881e7ee3e6509555 100644

--- a/base/strings/string_number_conversions.cc

+++ b/base/strings/string_number_conversions.cc

@@ -186,7 +186,9 @@ class IteratorRangeToNumber {

}

if (begin != end && *begin == '-') {

- if (!Negative::Invoke(begin + 1, end, output)) {

+ if (!std::numeric_limits<value_type>::is_signed) {

+ valid = false;

+ } else if (!Negative::Invoke(begin + 1, end, output)) {

valid = false;

}

} else {