Issue 14105010: Fix the rows' height computation with vertical-align: baseline and rowspan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14105010: Fix the rows' height computation with vertical-align: baseline and rowspan (Closed)

Created:
7 years, 8 months ago by Julien - ping for review

Modified:
7 years, 7 months ago

Reviewers:
rhogan, ojan

CC:
blink-reviews, jchaffraix+rendering, esprehn, eseidel

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix the rows' height computation with vertical-align: baseline and rowspan r140907 was careful in avoiding updating the baseline descent for spanning cells. However it still added the non-spanning cells baseline descent to the spanning cells' row height computation. This change avoids the previous issue by not adding the baseline descent in this case. BUG=227017 TEST=fast/table/baseline-align-rowspan.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149612

Patch Set 1 #

Patch Set 2 : Same as #1 but with the expected file #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -3 lines)			Patch
A	LayoutTests/fast/table/baseline-align-rowspan.html	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/table/baseline-align-rowspan-expected.txt	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderTableSection.cpp	View		1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/14105010/7004

7 years, 7 months ago (2013-05-02 20:23:32 UTC) #5

Message was sent while issue was closed.

Change committed as 149612

Expand Messages | Collapse Messages