Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 14105010: Fix the rows' height computation with vertical-align: baseline and rowspan (Closed)

Created:
7 years, 8 months ago by Julien - ping for review
Modified:
7 years, 7 months ago
Reviewers:
rhogan, ojan
CC:
blink-reviews, jchaffraix+rendering, esprehn, eseidel
Visibility:
Public.

Description

Fix the rows' height computation with vertical-align: baseline and rowspan r140907 was careful in avoiding updating the baseline descent for spanning cells. However it still added the non-spanning cells baseline descent to the spanning cells' row height computation. This change avoids the previous issue by not adding the baseline descent in this case. BUG=227017 TEST=fast/table/baseline-align-rowspan.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149612

Patch Set 1 #

Patch Set 2 : Same as #1 but with the expected file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
A LayoutTests/fast/table/baseline-align-rowspan.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/baseline-align-rowspan-expected.txt View 1 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Julien - ping for review
7 years, 8 months ago (2013-04-26 01:49:18 UTC) #1
rhogan
lgtm As
7 years, 7 months ago (2013-05-02 18:47:12 UTC) #2
rhogan
Whoops - just meant to say, yes this looks good to me!
7 years, 7 months ago (2013-05-02 18:48:01 UTC) #3
ojan
lgtm
7 years, 7 months ago (2013-05-02 20:19:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/14105010/7004
7 years, 7 months ago (2013-05-02 20:23:32 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-02 20:50:05 UTC) #6
Message was sent while issue was closed.
Change committed as 149612

Powered by Google App Engine
This is Rietveld 408576698