Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1410183004: Add instruction 'adc (register)' to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M src/IceAssemblerARM32.cpp View 1 2 chunks +18 lines, -3 lines 0 comments Download
M tests_lit/assembler/arm32/add.ll View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Karl
5 years, 1 month ago (2015-10-27 19:42:04 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1410183004/diff/1/src/IceAssemblerARM32.cpp File src/IceAssemblerARM32.cpp (right): https://codereview.chromium.org/1410183004/diff/1/src/IceAssemblerARM32.cpp#newcode380 src/IceAssemblerARM32.cpp:380: // ADC (Immediated) - ARM section A8.8.1, encoding ...
5 years, 1 month ago (2015-10-27 21:35:42 UTC) #4
Karl
Committed patchset #2 (id:20001) manually as 6a3b5154d7699421618f870d97ae4ab9f753ad7b (presubmit successful).
5 years, 1 month ago (2015-10-27 22:21:07 UTC) #5
Karl
5 years, 1 month ago (2015-10-27 22:21:36 UTC) #6
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/1410183004/diff/1/src/IceAssemblerARM3...
File src/IceAssemblerARM32.cpp (right):

https://chromiumcodereview.appspot.com/1410183004/diff/1/src/IceAssemblerARM3...
src/IceAssemblerARM32.cpp:380: // ADC (Immediated) - ARM section A8.8.1,
encoding A1:
On 2015/10/27 21:35:42, stichnot wrote:
> "Immediated" ?

Done.

Powered by Google App Engine
This is Rietveld 408576698