Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 14087009: Verify that the image is not empty before calling memset(). (Closed)

Created:
7 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 8 months ago
Reviewers:
yzshen, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@missing-include-for-epoll-io
Visibility:
Public.

Description

Verify that the image is not empty before calling memset(). Building with _FORTIFY_SOURCE=2 and NDEBUG set makes glibc complain that the call to memset() in TestGraphics2D::TestInitToZero() can have a 0-byte size argument. Avoid the warning by asserting that the image does have a valid area before using its height in the call to memset(). R=brettw, yzshen BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ppapi/tests/test_graphics_2d.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Raphael Kubo da Costa (rakuco)
7 years, 8 months ago (2013-04-17 12:46:32 UTC) #1
brettw
I will defer to Yuzhu.
7 years, 8 months ago (2013-04-17 17:44:27 UTC) #2
brettw
Actually, Yuzhu may be out. LGTM.
7 years, 8 months ago (2013-04-17 17:45:13 UTC) #3
Raphael Kubo da Costa (rakuco)
On 2013/04/17 17:45:13, brettw wrote: > Actually, Yuzhu may be out. LGTM. Thanks. Can you ...
7 years, 8 months ago (2013-04-17 17:51:56 UTC) #4
brettw
The CQ is offline now (crbug.com/231428) and I don't have time to do a manual ...
7 years, 8 months ago (2013-04-17 17:54:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/14087009/1
7 years, 8 months ago (2013-04-18 07:26:08 UTC) #6
commit-bot: I haz the power
Presubmit check for 14087009-1 failed and returned exit status 1. INFO:root:Found 1 file(s). INFO:PRESUBMIT:Valid authors ...
7 years, 8 months ago (2013-04-18 07:26:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/14087009/1
7 years, 8 months ago (2013-04-18 10:24:54 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 12:07:25 UTC) #9
Message was sent while issue was closed.
Change committed as 194893

Powered by Google App Engine
This is Rietveld 408576698