ppapi/tests/test_graphics_2d.cc - Issue 14087009: Verify that the image is not empty before calling memset().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/tests/test_graphics_2d.cc

Issue 14087009: Verify that the image is not empty before calling memset(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@missing-include-for-epoll-io

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/tests/test_graphics_2d.cc

diff --git a/ppapi/tests/test_graphics_2d.cc b/ppapi/tests/test_graphics_2d.cc

index 7377736b47fdea9069a53e1c0d6e3727f6785587..23a4fe76fb41abaa9499cfc3de74fd0c8bb089eb 100644

--- a/ppapi/tests/test_graphics_2d.cc

+++ b/ppapi/tests/test_graphics_2d.cc

@@ -321,6 +321,7 @@ std::string TestGraphics2D::TestInitToZero() {

pp::ImageData image(instance_, PP_IMAGEDATAFORMAT_BGRA_PREMUL,

pp::Size(w, h), true);

ASSERT_FALSE(image.is_null());

+ ASSERT_FALSE(image.size().IsEmpty());

memset(image.data(), 0xFF, image.stride() * image.size().height() * 4);

// Read out the initial data from the device & check.

« no previous file with comments | « no previous file | no next file » | no next file with comments »