runtime/vm/pages.h - Issue 1408653002: Skip making code pages temporarily writable when finalizing the VM isolate loaded from precompiled …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/pages.h

Issue 1408653002: Skip making code pages temporarily writable when finalizing the VM isolate loaded from precompiled … (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/pages.h

diff --git a/runtime/vm/pages.h b/runtime/vm/pages.h

index 39ef84eff191e593f28963e18e8054b9ae0300cc..17d1674d69c48d5c40eb13ad368b0ca810753975 100644

--- a/runtime/vm/pages.h

+++ b/runtime/vm/pages.h

@@ -284,7 +284,7 @@ class PageSpace {

// Note: Code pages are made executable/non-executable when 'read_only' is

// true/false, respectively.

- void WriteProtect(bool read_only);

+ void WriteProtect(bool read_only, bool include_code_pages);

void WriteProtectCode(bool read_only);

void AddGCTime(int64_t micros) {

« runtime/vm/heap.h ('K') | « runtime/vm/object.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »