Issue 1408653002: Skip making code pages temporarily writable when finalizing the VM isolate loaded from precompiled …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408653002: Skip making code pages temporarily writable when finalizing the VM isolate loaded from precompiled … (Closed)

Created:
5 years, 2 months ago by rmacnak

Modified:
5 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Skip making code pages temporarily writable when finalizing the VM isolate loaded from precompiled snapshot. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/d8490425c81f1f2d54c18b0093042642f063b2ab

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -14 lines)			Patch
M	runtime/vm/heap.h	View	2 chunks	+5 lines, -2 lines	1 comment	Download
M	runtime/vm/heap.cc	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/vm/heap_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/pages.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/pages.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

siva

lgtm https://chromiumcodereview.appspot.com/1408653002/diff/1/runtime/vm/heap.h File runtime/vm/heap.h (right): https://chromiumcodereview.appspot.com/1408653002/diff/1/runtime/vm/heap.h#newcode380 runtime/vm/heap.h:380: explicit WritableVMIsolateScope(Thread* thread, bool include_code_pages); not explicit anymore ...

5 years, 2 months ago (2015-10-15 01:01:29 UTC) #3

rmacnak

5 years, 2 months ago (2015-10-15 20:45:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d8490425c81f1f2d54c18b0093042642f063b2ab (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages