Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 14070021: Rename 'UseCounter::observe' to 'UseCounter::count'. (Closed)

Created:
7 years, 8 months ago by Mike West
Modified:
7 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, jsbell, abarth-chromium, pdr, f(malita), gavinp+loader_chromium.org, jchaffraix+rendering, haraken, Stephen Chennney, Nate Chapin, mkwst+watchlist_chromium.org
Visibility:
Public.

Description

Rename 'UseCounter::observe' to 'UseCounter::measureFeature'. Observation is a leftover concept from the class's old name ("FeatureObserver") and doesn't make much sense in the new class. Renaming the methods to "count" and "countDeprecation" seems more clear. This mechanical patch was brought to you by 'sed', 'ack', and the letter 'e'. BUG=233522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149193

Patch Set 1 #

Patch Set 2 : re-rename. #

Patch Set 3 : rebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObj.cpp View 1 2 12 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventTarget.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDataListElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 3 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/InputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/ContentSecurityPolicy.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/UseCounter.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/page/UseCounter.cpp View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTRefElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/Worker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
eseidel
Fine with me. I'm not sure these need to say "Feature" in the name since ...
7 years, 8 months ago (2013-04-26 09:23:54 UTC) #1
eseidel
We could also all it "count" :) or "record". I really don't have strong feelings ...
7 years, 8 months ago (2013-04-26 09:24:32 UTC) #2
eseidel
lgtm rs=me.
7 years, 8 months ago (2013-04-26 09:24:51 UTC) #3
Mike West
On 2013/04/26 09:24:51, Eric Seidel (Google) wrote: > lgtm > > rs=me. Let's run with ...
7 years, 8 months ago (2013-04-26 09:38:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/14070021/5001
7 years, 8 months ago (2013-04-26 09:45:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=3042
7 years, 8 months ago (2013-04-26 10:41:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/14070021/6022
7 years, 8 months ago (2013-04-26 11:22:20 UTC) #7
Mike West
7 years, 8 months ago (2013-04-26 11:44:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r149193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698