Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: Source/core/page/UseCounter.h

Issue 14070021: Rename 'UseCounter::observe' to 'UseCounter::count'. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaseline. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/core/page/UseCounter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/UseCounter.h
diff --git a/Source/core/page/UseCounter.h b/Source/core/page/UseCounter.h
index 73a36212e741b9d3c07691d73063357c926e06a5..fc21e7c696ec852a7c3efbe746691ea4b5709fd0 100644
--- a/Source/core/page/UseCounter.h
+++ b/Source/core/page/UseCounter.h
@@ -134,24 +134,24 @@ public:
NumberOfFeatures, // This enum value must be last.
};
- // "observe" sets the bit for this feature to 1. Repeated calls are ignored.
- static void observe(Document*, Feature);
- static void observe(DOMWindow*, Feature);
+ // "count" sets the bit for this feature to 1. Repeated calls are ignored.
+ static void count(Document*, Feature);
+ static void count(DOMWindow*, Feature);
- // "measureDeprecatedFeature" sets the bit for this feature to 1, and sends a deprecation
+ // "countDeprecation" sets the bit for this feature to 1, and sends a deprecation
// warning to the console. Repeated calls are ignored.
//
// Be considerate to developers' consoles: features should only send deprecation warnings
// when we're actively interested in removing them from the platform.
- static void measureDeprecatedFeature(DOMWindow*, Feature);
- static void measureDeprecatedFeature(ScriptExecutionContext*, Feature);
- static void measureDeprecatedFeature(Document*, Feature);
+ static void countDeprecation(DOMWindow*, Feature);
+ static void countDeprecation(ScriptExecutionContext*, Feature);
+ static void countDeprecation(Document*, Feature);
String deprecationMessage(Feature);
void didCommitLoad();
private:
- bool recordObservation(Feature feature)
+ bool recordMeasurement(Feature feature)
{
ASSERT(feature != PageDestruction); // PageDestruction is reserved as a scaling factor.
ASSERT(feature < NumberOfFeatures);
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/core/page/UseCounter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698