Issue 14070014: Remove |third_party| from InputMethodDescriptor.

Issue 14070014: Remove |third_party| from InputMethodDescriptor. (Closed)

Created:
7 years, 8 months ago by Seigo Nonaka

Modified:
7 years, 8 months ago

Reviewers:
Nikita (slow), satorux1, Ben Goodger (Google)

CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove |third_party| from InputMethodDescriptor. All third party input method is provided as Extension IME, thus we don't need to use additional field, just check with |id|. BUG=None TEST=Confirmed still asterisk is shown for extension IME as the indicator of third party IME. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195252

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -26 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_input_method_manager.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/system/ash_system_tray_delegate.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chromeos/ime/component_extension_ime_manager.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chromeos/ime/input_method_descriptor.h	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	chromeos/ime/input_method_descriptor.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	chromeos/ime/input_method_descriptor_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chromeos/ime/input_method_whitelist.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Seigo Nonaka

Hi Satoru, Could you take a look at this CL? Thank you.

7 years, 8 months ago (2013-04-18 18:24:33 UTC) #1

Seigo Nonaka

Satoru: Thank you for your review! Adding owners. Hi Ben and Nikita, Could you take ...

7 years, 8 months ago (2013-04-19 04:50:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14070014/1

7 years, 8 months ago (2013-04-19 17:09:03 UTC) #6

Message was sent while issue was closed.

Change committed as 195252

Expand Messages | Collapse Messages