Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chromeos/ime/input_method_descriptor.cc

Issue 14070014: Remove |third_party| from InputMethodDescriptor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/ime/input_method_descriptor.h" 5 #include "chromeos/ime/input_method_descriptor.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/strings/string_split.h" 10 #include "base/strings/string_split.h"
11 11
12 namespace chromeos { 12 namespace chromeos {
13 namespace input_method { 13 namespace input_method {
14 14
15 InputMethodDescriptor::InputMethodDescriptor( 15 InputMethodDescriptor::InputMethodDescriptor(
16 const std::string& id, 16 const std::string& id,
17 const std::string& name, 17 const std::string& name,
18 const std::string& keyboard_layout, 18 const std::string& keyboard_layout,
19 const std::string& language_code, 19 const std::string& language_code,
20 const std::string& options_page_url, 20 const std::string& options_page_url)
21 bool third_party)
22 : id_(id), 21 : id_(id),
23 name_(name), 22 name_(name),
24 keyboard_layout_(keyboard_layout), 23 keyboard_layout_(keyboard_layout),
25 language_code_(language_code), 24 language_code_(language_code),
26 options_page_url_(options_page_url), 25 options_page_url_(options_page_url) {
27 third_party_(third_party) {
28 } 26 }
29 27
30 InputMethodDescriptor::InputMethodDescriptor() : third_party_(false) { 28 InputMethodDescriptor::InputMethodDescriptor() {
31 } 29 }
32 30
33 InputMethodDescriptor::~InputMethodDescriptor() { 31 InputMethodDescriptor::~InputMethodDescriptor() {
34 } 32 }
35 33
36 bool InputMethodDescriptor::operator==( 34 bool InputMethodDescriptor::operator==(
37 const InputMethodDescriptor& other) const { 35 const InputMethodDescriptor& other) const {
38 return id() == other.id(); 36 return id() == other.id();
39 } 37 }
40 38
41 bool InputMethodDescriptor::operator!=( 39 bool InputMethodDescriptor::operator!=(
42 const InputMethodDescriptor& other) const { 40 const InputMethodDescriptor& other) const {
43 return !(*this == other); 41 return !(*this == other);
44 } 42 }
45 43
46 } // namespace input_method 44 } // namespace input_method
47 } // namespace chromeos 45 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/ime/input_method_descriptor.h ('k') | chromeos/ime/input_method_descriptor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698