Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14065003: Rename DAYS_IN_WEEK to DAYS_PER_WEEK. Add MONTHS_PER_YEAR. (Closed)

Created:
7 years, 8 months ago by floitsch
Modified:
7 years, 8 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename DAYS_IN_WEEK to DAYS_PER_WEEK. Add MONTHS_PER_YEAR. BUG= http://dartbug.com/9812 Committed: https://code.google.com/p/dart/source/detail?r=21434

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M runtime/lib/date_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/util/DateUtils.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/core/date_time.dart View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
7 years, 8 months ago (2013-04-10 13:44:36 UTC) #1
floitsch
ping
7 years, 8 months ago (2013-04-11 13:57:32 UTC) #2
floitsch
7 years, 8 months ago (2013-04-15 09:38:16 UTC) #3
Anders Johnsen
lgtm https://chromiumcodereview.appspot.com/14065003/diff/1/samples/swarm/swarm_ui_lib/util/DateUtils.dart File samples/swarm/swarm_ui_lib/util/DateUtils.dart (right): https://chromiumcodereview.appspot.com/14065003/diff/1/samples/swarm/swarm_ui_lib/util/DateUtils.dart#newcode17 samples/swarm/swarm_ui_lib/util/DateUtils.dart:17: static const MS_IN_WEEK = DateTime.DAYS_PER_WEEK * Duration.MILLISECONDS_PER_DAY; Long ...
7 years, 8 months ago (2013-04-15 10:28:06 UTC) #4
floitsch
https://chromiumcodereview.appspot.com/14065003/diff/1/samples/swarm/swarm_ui_lib/util/DateUtils.dart File samples/swarm/swarm_ui_lib/util/DateUtils.dart (right): https://chromiumcodereview.appspot.com/14065003/diff/1/samples/swarm/swarm_ui_lib/util/DateUtils.dart#newcode17 samples/swarm/swarm_ui_lib/util/DateUtils.dart:17: static const MS_IN_WEEK = DateTime.DAYS_PER_WEEK * Duration.MILLISECONDS_PER_DAY; On 2013/04/15 ...
7 years, 8 months ago (2013-04-15 11:28:00 UTC) #5
floitsch
7 years, 8 months ago (2013-04-15 11:29:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r21434 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698