Implemented argument wrapping for CallJS.

chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc

Index: chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
index 6ce65e6e5a4fc528b02fb3f1880dbc1613dc3689..bf2e7f8965abf0a61c6d88df234b003fc65c29ea 100644
--- a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc
@@ -99,11 +99,8 @@ void UserImageScreenHandler::PrepareToShow() {
 
 void UserImageScreenHandler::SelectImage(int index) {
   selected_image_ = index;
-  if (page_is_ready()) {
-    base::StringValue image_url(GetDefaultImageUrl(index));
-    CallJS("oobe.UserImageScreen.setSelectedImage",
-           image_url);
-  }
+  if (page_is_ready())
+    CallJS("oobe.UserImageScreen.setSelectedImage", GetDefaultImageUrl(index));
 }
 
 void UserImageScreenHandler::CheckCameraPresence() {
@@ -130,10 +127,8 @@ void UserImageScreenHandler::AddProfileImage(const gfx::ImageSkia& image) {
 }
 
 void UserImageScreenHandler::SendProfileImage(const std::string& data_url) {
-  if (page_is_ready()) {
-    base::StringValue data_url_value(data_url);
-    CallJS("oobe.UserImageScreen.setProfileImage", data_url_value);
-  }
+  if (page_is_ready())
+    CallJS("oobe.UserImageScreen.setProfileImage", data_url);
 }
 
 void UserImageScreenHandler::OnProfileImageAbsent() {
@@ -239,9 +234,9 @@ void UserImageScreenHandler::HandleScreenShown() {
 }
 
 void UserImageScreenHandler::OnCameraPresenceCheckDone() {
-  base::FundamentalValue present_value(
-      CameraDetector::camera_presence() == CameraDetector::kCameraPresent);
-  CallJS("oobe.UserImageScreen.setCameraPresent", present_value);
+  bool present =
+      (CameraDetector::camera_presence() == CameraDetector::kCameraPresent);
+  CallJS("oobe.UserImageScreen.setCameraPresent", present);

[bartfab (slow), 2013/04/18 07:39:31]

Nit: You can inline the comparison here:

CallJS("oobe.UserImageScreen.setCameraPresent",
       CameraDetector::camera_presence() == CameraDetector::kCameraPresent);

Alternatively, if you prefer having a |present| variable:
1/ Make it const.
2/ Remove the unnecessary braces around "CameraDetector::camera_presence() ==
CameraDetector::kCameraPresent"

[Denis Kuznetsov (DE-MUC), 2013/04/18 07:46:52]

That would actually be gone when https://codereview.chromium.org/14063017/ lands

[ygorshenin1, 2013/04/18 07:58:23]

Done.

 }
 
 void UserImageScreenHandler::OnImageDecoded(const ImageDecoder* decoder,
@@ -257,8 +252,7 @@ void UserImageScreenHandler::OnDecodeImageFailed(const ImageDecoder* decoder) {
 }
 
 void UserImageScreenHandler::SetProfilePictureEnabled(bool enabled) {
-  base::FundamentalValue present_value(enabled);
-  CallJS("oobe.UserImageScreen.setProfilePictureEnabled", present_value);
+  CallJS("oobe.UserImageScreen.setProfilePictureEnabled", enabled);
 }
 
 }  // namespace chromeos