Implemented argument wrapping for CallJS.

chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/values.h"
@@ skipping 81 matching lines @@
 }
 
 void UserImageScreenHandler::Hide() {
 }
 
 void UserImageScreenHandler::PrepareToShow() {
 }
 
 void UserImageScreenHandler::SelectImage(int index) {
   selected_image_ = index;
-  if (page_is_ready()) {
-    base::StringValue image_url(GetDefaultImageUrl(index));
-    CallJS("oobe.UserImageScreen.setSelectedImage",
-           image_url);
-  }
+  if (page_is_ready())
+    CallJS("oobe.UserImageScreen.setSelectedImage", GetDefaultImageUrl(index));
 }
 
 void UserImageScreenHandler::CheckCameraPresence() {
   CameraDetector::StartPresenceCheck(
       base::Bind(&UserImageScreenHandler::OnCameraPresenceCheckDone,
                  weak_factory_.GetWeakPtr()));
 }
 
 void UserImageScreenHandler::RegisterMessages() {
   AddCallback("getImages", &UserImageScreenHandler::HandleGetImages);
   AddCallback("photoTaken", &UserImageScreenHandler::HandlePhotoTaken);
   AddCallback("selectImage", &UserImageScreenHandler::HandleSelectImage);
   AddCallback("checkCameraPresence",
               &UserImageScreenHandler::HandleCheckCameraPresence);
   AddCallback("onUserImageAccepted",
               &UserImageScreenHandler::HandleImageAccepted);
   AddCallback("onUserImageScreenShown",
               &UserImageScreenHandler::HandleScreenShown);
 }
 
 void UserImageScreenHandler::AddProfileImage(const gfx::ImageSkia& image) {
   profile_picture_data_url_ = webui::GetBitmapDataUrl(*image.bitmap());
   SendProfileImage(profile_picture_data_url_);
 }
 
 void UserImageScreenHandler::SendProfileImage(const std::string& data_url) {
-  if (page_is_ready()) {
-    base::StringValue data_url_value(data_url);
-    CallJS("oobe.UserImageScreen.setProfileImage", data_url_value);
-  }
+  if (page_is_ready())
+    CallJS("oobe.UserImageScreen.setProfileImage", data_url);
 }
 
 void UserImageScreenHandler::OnProfileImageAbsent() {
   profile_picture_absent_ = true;
   if (page_is_ready()) {
     scoped_ptr<base::Value> null_value(base::Value::CreateNullValue());
     CallJS("oobe.UserImageScreen.setProfileImage", *null_value);
   }
 }
 
@@ skipping 85 matching lines @@
 
 void UserImageScreenHandler::HandleScreenShown() {
   DCHECK(!screen_show_time_.is_null());
 
   base::TimeDelta delta = base::Time::Now() - screen_show_time_;
   VLOG(1) << "Screen load time: " << delta.InSecondsF();
   UMA_HISTOGRAM_TIMES("UserImage.ScreenIsShownTime", delta);
 }
 
 void UserImageScreenHandler::OnCameraPresenceCheckDone() {
-  base::FundamentalValue present_value(
-      CameraDetector::camera_presence() == CameraDetector::kCameraPresent);
-  CallJS("oobe.UserImageScreen.setCameraPresent", present_value);
+  bool present =
+      (CameraDetector::camera_presence() == CameraDetector::kCameraPresent);
+  CallJS("oobe.UserImageScreen.setCameraPresent", present);

[bartfab (slow), 2013/04/18 07:39:31]

Nit: You can inline the comparison here:

CallJS("oobe.UserImageScreen.setCameraPresent",
       CameraDetector::camera_presence() == CameraDetector::kCameraPresent);

Alternatively, if you prefer having a |present| variable:
1/ Make it const.
2/ Remove the unnecessary braces around "CameraDetector::camera_presence() ==
CameraDetector::kCameraPresent"

[Denis Kuznetsov (DE-MUC), 2013/04/18 07:46:52]

That would actually be gone when https://codereview.chromium.org/14063017/ lands

[ygorshenin1, 2013/04/18 07:58:23]

Done.

 }
 
 void UserImageScreenHandler::OnImageDecoded(const ImageDecoder* decoder,
                                             const SkBitmap& decoded_image) {
   DCHECK_EQ(image_decoder_.get(), decoder);
   user_photo_ = gfx::ImageSkia::CreateFrom1xBitmap(decoded_image);
   if (screen_ && accept_photo_after_decoding_)
     screen_->OnPhotoTaken(user_photo_);
 }
 
 void UserImageScreenHandler::OnDecodeImageFailed(const ImageDecoder* decoder) {
   NOTREACHED() << "Failed to decode PNG image from WebUI";
 }
 
 void UserImageScreenHandler::SetProfilePictureEnabled(bool enabled) {
-  base::FundamentalValue present_value(enabled);
-  CallJS("oobe.UserImageScreen.setProfilePictureEnabled", present_value);
+  CallJS("oobe.UserImageScreen.setProfilePictureEnabled", enabled);
 }
 
 }  // namespace chromeos