fix gcc 4.7 compilation errors in base_unittests

fix gcc 4.7 compilation errors in base_unittests

Compiling base_unittests with gcc 4.7 on linux gives these errors:
../../base/logging_unittest.cc: In member function 'virtual void logging::{anonymous}::LoggingTest_BasicLogging_Test::TestBody()':
../../base/logging_unittest.cc:68:172: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
../../base/logging_unittest.cc: In member function 'virtual void logging::{anonymous}::LoggingTest_LogIsOn_Test::TestBody()':
../../base/logging_unittest.cc:123:174: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
../../base/logging_unittest.cc:132:174: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
../../base/logging_unittest.cc:141:174: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]

Switching from EXPECT_EQ(false, something) to EXPECT_TRUE(false == something)
fixes the problem.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193872

[willchan no longer on Chromium, 2013-04-11 22:01:40]

Sorry for the delay, I apparently forgot to respond yesterday. LGTM. Do you have
commit access? If not, have you added yourself to AUTHORS yet? If you haven't
done any of that, you need to follow the steps to signing up for that. I think
they're explained here:
http://dev.chromium.org/developers/contributing-code#TOC-If-you-are-not-a-com....
You need to sign whatever that license thingy is too. Let me know if you've done
so and I can go verify and what not.

[commit-bot: I haz the power, 2013-04-11 22:10:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mostynb@opera.com/14019004/1

[Mostyn Bramley-Moore, 2013-04-11 22:14:41]

On 2013/04/11 22:01:40, willchan wrote:
> Sorry for the delay, I apparently forgot to respond yesterday. LGTM. Do you
have
> commit access? If not, have you added yourself to AUTHORS yet? If you haven't
> done any of that, you need to follow the steps to signing up for that. I think
> they're explained here:
>
http://dev.chromium.org/developers/contributing-code#TOC-If-you-are-not-a-com....
> You need to sign whatever that license thingy is too. Let me know if you've
done
> so and I can go verify and what not.

I don't have commit access.

I previously added *@opera.com to the AUTHORS file (we have a company-wide CLA
signed already).

[willchan no longer on Chromium, 2013-04-11 22:15:36]

Perfect.


On Thu, Apr 11, 2013 at 3:14 PM, <mostynb@opera.com> wrote:

> On 2013/04/11 22:01:40, willchan wrote:
>
>> Sorry for the delay, I apparently forgot to respond yesterday. LGTM. Do
>> you
>>
> have
>
>> commit access? If not, have you added yourself to AUTHORS yet? If you
>> haven't
>> done any of that, you need to follow the steps to signing up for that. I
>> think
>> they're explained here:
>>
>
> http://dev.chromium.org/**developers/contributing-code#**
>
TOC-If-you-are-not-a-**committer-yet<http://dev.chromium.org/developers/contributing-code#TOC-If-you-are-not-a-committer-yet>
> .
>
>> You need to sign whatever that license thingy is too. Let me know if
>> you've
>>
> done
>
>> so and I can go verify and what not.
>>
>
> I don't have commit access.
>
> I previously added *@opera.com to the AUTHORS file (we have a
> company-wide CLA
> signed already).
>
>
https://codereview.chromium.**org/14019004/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-04-12 07:31:16]

Change committed as 193872