Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: base/logging_unittest.cc

Issue 14019004: fix gcc 4.7 compilation errors in base_unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/logging.h" 6 #include "base/logging.h"
7 7
8 #include "testing/gmock/include/gmock/gmock.h" 8 #include "testing/gmock/include/gmock/gmock.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 kExpectedDebugOrReleaseCalls + (DEBUG_MODE ? kExpectedDebugCalls : 0); 58 kExpectedDebugOrReleaseCalls + (DEBUG_MODE ? kExpectedDebugCalls : 0);
59 EXPECT_CALL(mock_log_source, Log()).Times(kExpectedCalls). 59 EXPECT_CALL(mock_log_source, Log()).Times(kExpectedCalls).
60 WillRepeatedly(Return("log message")); 60 WillRepeatedly(Return("log message"));
61 61
62 SetMinLogLevel(LOG_INFO); 62 SetMinLogLevel(LOG_INFO);
63 63
64 EXPECT_TRUE(LOG_IS_ON(INFO)); 64 EXPECT_TRUE(LOG_IS_ON(INFO));
65 // As of g++-4.5, the first argument to EXPECT_EQ cannot be a 65 // As of g++-4.5, the first argument to EXPECT_EQ cannot be a
66 // constant expression. 66 // constant expression.
67 const bool kIsDebugMode = (DEBUG_MODE != 0); 67 const bool kIsDebugMode = (DEBUG_MODE != 0);
68 EXPECT_EQ(kIsDebugMode, DLOG_IS_ON(INFO)); 68 EXPECT_TRUE(kIsDebugMode == DLOG_IS_ON(INFO));
69 EXPECT_TRUE(VLOG_IS_ON(0)); 69 EXPECT_TRUE(VLOG_IS_ON(0));
70 70
71 LOG(INFO) << mock_log_source.Log(); 71 LOG(INFO) << mock_log_source.Log();
72 LOG_IF(INFO, true) << mock_log_source.Log(); 72 LOG_IF(INFO, true) << mock_log_source.Log();
73 PLOG(INFO) << mock_log_source.Log(); 73 PLOG(INFO) << mock_log_source.Log();
74 PLOG_IF(INFO, true) << mock_log_source.Log(); 74 PLOG_IF(INFO, true) << mock_log_source.Log();
75 VLOG(0) << mock_log_source.Log(); 75 VLOG(0) << mock_log_source.Log();
76 VLOG_IF(0, true) << mock_log_source.Log(); 76 VLOG_IF(0, true) << mock_log_source.Log();
77 77
78 DLOG(INFO) << mock_log_source.Log(); 78 DLOG(INFO) << mock_log_source.Log();
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT)); 113 EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
114 EXPECT_TRUE(LOG_IS_ON(FATAL)); 114 EXPECT_TRUE(LOG_IS_ON(FATAL));
115 EXPECT_TRUE(LOG_IS_ON(DFATAL)); 115 EXPECT_TRUE(LOG_IS_ON(DFATAL));
116 116
117 SetMinLogLevel(LOG_ERROR_REPORT); 117 SetMinLogLevel(LOG_ERROR_REPORT);
118 EXPECT_FALSE(LOG_IS_ON(INFO)); 118 EXPECT_FALSE(LOG_IS_ON(INFO));
119 EXPECT_FALSE(LOG_IS_ON(WARNING)); 119 EXPECT_FALSE(LOG_IS_ON(WARNING));
120 EXPECT_FALSE(LOG_IS_ON(ERROR)); 120 EXPECT_FALSE(LOG_IS_ON(ERROR));
121 EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT)); 121 EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
122 EXPECT_TRUE(LOG_IS_ON(FATAL)); 122 EXPECT_TRUE(LOG_IS_ON(FATAL));
123 EXPECT_EQ(kDfatalIsFatal, LOG_IS_ON(DFATAL)); 123 EXPECT_TRUE(kDfatalIsFatal == LOG_IS_ON(DFATAL));
124 124
125 // LOG_IS_ON(ERROR_REPORT) should always be true. 125 // LOG_IS_ON(ERROR_REPORT) should always be true.
126 SetMinLogLevel(LOG_FATAL); 126 SetMinLogLevel(LOG_FATAL);
127 EXPECT_FALSE(LOG_IS_ON(INFO)); 127 EXPECT_FALSE(LOG_IS_ON(INFO));
128 EXPECT_FALSE(LOG_IS_ON(WARNING)); 128 EXPECT_FALSE(LOG_IS_ON(WARNING));
129 EXPECT_FALSE(LOG_IS_ON(ERROR)); 129 EXPECT_FALSE(LOG_IS_ON(ERROR));
130 EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT)); 130 EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
131 EXPECT_TRUE(LOG_IS_ON(FATAL)); 131 EXPECT_TRUE(LOG_IS_ON(FATAL));
132 EXPECT_EQ(kDfatalIsFatal, LOG_IS_ON(DFATAL)); 132 EXPECT_TRUE(kDfatalIsFatal == LOG_IS_ON(DFATAL));
133 133
134 // So should LOG_IS_ON(FATAL). 134 // So should LOG_IS_ON(FATAL).
135 SetMinLogLevel(LOG_FATAL + 1); 135 SetMinLogLevel(LOG_FATAL + 1);
136 EXPECT_FALSE(LOG_IS_ON(INFO)); 136 EXPECT_FALSE(LOG_IS_ON(INFO));
137 EXPECT_FALSE(LOG_IS_ON(WARNING)); 137 EXPECT_FALSE(LOG_IS_ON(WARNING));
138 EXPECT_FALSE(LOG_IS_ON(ERROR)); 138 EXPECT_FALSE(LOG_IS_ON(ERROR));
139 EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT)); 139 EXPECT_TRUE(LOG_IS_ON(ERROR_REPORT));
140 EXPECT_TRUE(LOG_IS_ON(FATAL)); 140 EXPECT_TRUE(LOG_IS_ON(FATAL));
141 EXPECT_EQ(kDfatalIsFatal, LOG_IS_ON(DFATAL)); 141 EXPECT_TRUE(kDfatalIsFatal == LOG_IS_ON(DFATAL));
142 } 142 }
143 143
144 TEST_F(LoggingTest, LoggingIsLazy) { 144 TEST_F(LoggingTest, LoggingIsLazy) {
145 MockLogSource mock_log_source; 145 MockLogSource mock_log_source;
146 EXPECT_CALL(mock_log_source, Log()).Times(0); 146 EXPECT_CALL(mock_log_source, Log()).Times(0);
147 147
148 SetMinLogLevel(LOG_WARNING); 148 SetMinLogLevel(LOG_WARNING);
149 149
150 EXPECT_FALSE(LOG_IS_ON(INFO)); 150 EXPECT_FALSE(LOG_IS_ON(INFO));
151 EXPECT_FALSE(DLOG_IS_ON(INFO)); 151 EXPECT_FALSE(DLOG_IS_ON(INFO));
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 // These should still reference |some_variable| so we don't get 252 // These should still reference |some_variable| so we don't get
253 // unused variable warnings. 253 // unused variable warnings.
254 DCHECK(some_variable) << "test"; 254 DCHECK(some_variable) << "test";
255 DPCHECK(some_variable) << "test"; 255 DPCHECK(some_variable) << "test";
256 DCHECK_EQ(some_variable, 1) << "test"; 256 DCHECK_EQ(some_variable, 1) << "test";
257 } 257 }
258 258
259 } // namespace 259 } // namespace
260 260
261 } // namespace logging 261 } // namespace logging
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698