Issue 13993008: Remove the LowMemoryMargin field trial.

Issue 13993008: Remove the LowMemoryMargin field trial. (Closed)

Created:
7 years, 8 months ago by SteveT

Modified:
7 years, 8 months ago

Reviewers:
Greg Spencer (Chromium), stevenjb

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, James Cook

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove the LowMemoryMargin field trial. BUG=229940 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193476

Patch Set 2 : Patch in Greg's cleanup code #

Total comments: 2

Patch Set 3 : remove header decl #

Total comments: 2

Patch Set 4 : clean up comment #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -73 lines)			Patch
M	chrome/browser/chromeos/chrome_browser_main_chromeos.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View		1 chunk	+0 lines, -48 lines	0 comments	Download
M	chrome/browser/chromeos/memory/oom_priority_manager.cc	View	1	7 chunks	+13 lines, -23 lines	0 comments	Download

Messages

Total messages: 16 (0 generated)

Expand Messages | Collapse Messages

SteveT

Hi Greg, Here's a patch to remove the old Field Trial. As for the usage ...

7 years, 8 months ago (2013-04-10 14:35:19 UTC) #1

Greg Spencer (Chromium)

https://codereview.chromium.org/13993008/diff/4001/chrome/browser/chromeos/chrome_browser_main_chromeos.cc File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (left): https://codereview.chromium.org/13993008/diff/4001/chrome/browser/chromeos/chrome_browser_main_chromeos.cc#oldcode791 chrome/browser/chromeos/chrome_browser_main_chromeos.cc:791: void ChromeBrowserMainPartsChromeos::SetupLowMemoryHeadroomFieldTrial() { When you remove this, you also ...

7 years, 8 months ago (2013-04-10 18:21:03 UTC) #3

SteveT

Back to you. https://codereview.chromium.org/13993008/diff/4001/chrome/browser/chromeos/chrome_browser_main_chromeos.cc File chrome/browser/chromeos/chrome_browser_main_chromeos.cc (left): https://codereview.chromium.org/13993008/diff/4001/chrome/browser/chromeos/chrome_browser_main_chromeos.cc#oldcode791 chrome/browser/chromeos/chrome_browser_main_chromeos.cc:791: void ChromeBrowserMainPartsChromeos::SetupLowMemoryHeadroomFieldTrial() { On 2013/04/10 18:21:03, ...

7 years, 8 months ago (2013-04-10 18:25:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/13993008/10001

7 years, 8 months ago (2013-04-10 18:26:51 UTC) #6

commit-bot: I haz the power

Presubmit check for 13993008-10001 failed and returned exit status 1. INFO:root:Found 3 file(s). Running presubmit ...

7 years, 8 months ago (2013-04-10 18:26:59 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/13993008/10001

7 years, 8 months ago (2013-04-10 18:39:13 UTC) #10

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 8 months ago (2013-04-10 18:45:56 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/13993008/10001

7 years, 8 months ago (2013-04-10 18:48:12 UTC) #12

Greg Spencer (Chromium)

https://chromiumcodereview.appspot.com/13993008/diff/10001/chrome/browser/chromeos/chrome_browser_main_chromeos.h File chrome/browser/chromeos/chrome_browser_main_chromeos.h (right): https://chromiumcodereview.appspot.com/13993008/diff/10001/chrome/browser/chromeos/chrome_browser_main_chromeos.h#newcode73 chrome/browser/chromeos/chrome_browser_main_chromeos.h:73: // Set up field trial for low memory headroom ...

7 years, 8 months ago (2013-04-10 18:50:53 UTC) #13

SteveT

Thanks. Will re-CQ. https://chromiumcodereview.appspot.com/13993008/diff/10001/chrome/browser/chromeos/chrome_browser_main_chromeos.h File chrome/browser/chromeos/chrome_browser_main_chromeos.h (right): https://chromiumcodereview.appspot.com/13993008/diff/10001/chrome/browser/chromeos/chrome_browser_main_chromeos.h#newcode73 chrome/browser/chromeos/chrome_browser_main_chromeos.h:73: // Set up field trial for ...

7 years, 8 months ago (2013-04-10 18:55:23 UTC) #14

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/13993008/16003

7 years, 8 months ago (2013-04-10 18:55:54 UTC) #15

Message was sent while issue was closed.

Change committed as 193476

Expand Messages | Collapse Messages