Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 13993008: Remove the LowMemoryMargin field trial. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: clean up comment Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index 06cf2830af74bf4d26f52d2f478335b84d0858a7..f30f26be72997cc734bf6a3a4a57fc89f6135384 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -784,57 +784,9 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() {
}
void ChromeBrowserMainPartsChromeos::SetupPlatformFieldTrials() {
- SetupLowMemoryHeadroomFieldTrial();
SetupZramFieldTrial();
}
-void ChromeBrowserMainPartsChromeos::SetupLowMemoryHeadroomFieldTrial() {
- chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
- // Only enable this experiment on Canary and Dev, since it's possible
- // that this will make the machine unstable.
- // Note that to have this code execute in a developer build,
- // then chrome::VersionInfo::CHANNEL_UNKNOWN needs to be added here.
- if (channel == chrome::VersionInfo::CHANNEL_CANARY ||
- channel == chrome::VersionInfo::CHANNEL_DEV) {
- const base::FieldTrial::Probability kDivisor = 7;
- // 1 in 7 probability of being in each group. If the default value for the
- // kernel matches one of the experiment groups, then they will have
- // identical results.
- const base::FieldTrial::Probability kEnableProbability = 1;
- scoped_refptr<base::FieldTrial> trial =
- base::FieldTrialList::FactoryGetFieldTrial(
- "LowMemoryMargin", kDivisor, "default", 2012, 7, 30, NULL);
- int disable = trial->AppendGroup("off", kEnableProbability);
- int margin_0mb = trial->AppendGroup("0mb", kEnableProbability);
- int margin_25mb = trial->AppendGroup("25mb", kEnableProbability);
- int margin_50mb = trial->AppendGroup("50mb", kEnableProbability);
- int margin_100mb = trial->AppendGroup("100mb", kEnableProbability);
- int margin_200mb = trial->AppendGroup("200mb", kEnableProbability);
- if (trial->group() == disable) {
- LOG(WARNING) << "low_mem: Part of 'off' experiment";
- LowMemoryObserver::SetLowMemoryMargin(-1);
- } else if (trial->group() == margin_0mb) {
- LOG(WARNING) << "low_mem: Part of '0MB' experiment";
- LowMemoryObserver::SetLowMemoryMargin(0);
- } else if (trial->group() == margin_25mb) {
- LOG(WARNING) << "low_mem: Part of '25MB' experiment";
- LowMemoryObserver::SetLowMemoryMargin(25);
- } else if (trial->group() == margin_50mb) {
- LOG(WARNING) << "low_mem: Part of '50MB' experiment";
- LowMemoryObserver::SetLowMemoryMargin(50);
- } else if (trial->group() == margin_100mb) {
- LOG(WARNING) << "low_mem: Part of '100MB' experiment";
- LowMemoryObserver::SetLowMemoryMargin(100);
- } else if (trial->group() == margin_200mb) {
- LOG(WARNING) << "low_mem: Part of '200MB' experiment";
- LowMemoryObserver::SetLowMemoryMargin(200);
- } else {
- LOG(WARNING) << "low_mem: Part of 'default' experiment";
- }
- }
-}
-
-
void ChromeBrowserMainPartsChromeos::SetupZramFieldTrial() {
// The dice for this experiment have been thrown at boot. The selected group
// number is stored in a file.
« no previous file with comments | « chrome/browser/chromeos/chrome_browser_main_chromeos.h ('k') | chrome/browser/chromeos/memory/oom_priority_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698