Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 13982023: Do not dereference handles during relocation. (Closed)

Created:
7 years, 8 months ago by Yang
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Do not dereference handles during relocation. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14445

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M src/handles-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap.h View 2 chunks +30 lines, -0 lines 2 comments Download
M src/heap.cc View 4 chunks +20 lines, -0 lines 0 comments Download
M src/heap-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 8 months ago (2013-04-25 15:24:27 UTC) #1
Hannes Payer (out of office)
LGTM, with two nits https://codereview.chromium.org/13982023/diff/1/src/heap.h File src/heap.h (right): https://codereview.chromium.org/13982023/diff/1/src/heap.h#newcode1868 src/heap.h:1868: heap_->relocation_mutex_locked_by_optimizer_thread_ = false; Just set ...
7 years, 8 months ago (2013-04-26 07:27:47 UTC) #2
Yang
7 years, 8 months ago (2013-04-26 07:35:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14445 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698