Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Side by Side Diff: src/hydrogen.cc

Issue 13982023: Do not dereference handles during relocation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 } 504 }
505 505
506 int visited_count_; 506 int visited_count_;
507 ZoneList<HBasicBlock*> stack_; 507 ZoneList<HBasicBlock*> stack_;
508 BitVector reachable_; 508 BitVector reachable_;
509 HBasicBlock* dont_visit_; 509 HBasicBlock* dont_visit_;
510 }; 510 };
511 511
512 512
513 void HGraph::Verify(bool do_full_verify) const { 513 void HGraph::Verify(bool do_full_verify) const {
514 Heap::RelocationLock(isolate()->heap());
514 ALLOW_HANDLE_DEREF(isolate(), "debug mode verification"); 515 ALLOW_HANDLE_DEREF(isolate(), "debug mode verification");
515 for (int i = 0; i < blocks_.length(); i++) { 516 for (int i = 0; i < blocks_.length(); i++) {
516 HBasicBlock* block = blocks_.at(i); 517 HBasicBlock* block = blocks_.at(i);
517 518
518 block->Verify(); 519 block->Verify();
519 520
520 // Check that every block contains at least one node and that only the last 521 // Check that every block contains at least one node and that only the last
521 // node is a control instruction. 522 // node is a control instruction.
522 HInstruction* current = block->first(); 523 HInstruction* current = block->first();
523 ASSERT(current != NULL && current->IsBlockEntry()); 524 ASSERT(current != NULL && current->IsBlockEntry());
(...skipping 11395 matching lines...) Expand 10 before | Expand all | Expand 10 after
11919 } 11920 }
11920 } 11921 }
11921 11922
11922 #ifdef DEBUG 11923 #ifdef DEBUG
11923 if (graph_ != NULL) graph_->Verify(false); // No full verify. 11924 if (graph_ != NULL) graph_->Verify(false); // No full verify.
11924 if (allocator_ != NULL) allocator_->Verify(); 11925 if (allocator_ != NULL) allocator_->Verify();
11925 #endif 11926 #endif
11926 } 11927 }
11927 11928
11928 } } // namespace v8::internal 11929 } } // namespace v8::internal
OLDNEW
« src/heap.h ('K') | « src/heap-inl.h ('k') | src/mark-compact.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698