Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1397953005: dart2js cps: Speed up integrity checking some more. (Closed)

Created:
5 years, 2 months ago by asgerf
Modified:
5 years, 2 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Speed up integrity checking some more. Share the Map instance between different passes, so we don't need to allocate and resize the hash table from scratch every time. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/1e23ef0cbb1d50f3225a29eadaaf31ffd51b3cdc

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart View 2 chunks +4 lines, -7 lines 1 comment Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 2 chunks +7 lines, -1 line 2 comments Download

Messages

Total messages: 5 (1 generated)
asgerf
https://codereview.chromium.org/1397953005/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart File pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart (left): https://codereview.chromium.org/1397953005/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart#oldcode40 pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart:40: } This is an unused function I left here ...
5 years, 2 months ago (2015-10-15 10:13:29 UTC) #2
sra1
lgtm https://chromiumcodereview.appspot.com/1397953005/diff/1/pkg/compiler/lib/src/js_backend/codegen/task.dart File pkg/compiler/lib/src/js_backend/codegen/task.dart (right): https://chromiumcodereview.appspot.com/1397953005/diff/1/pkg/compiler/lib/src/js_backend/codegen/task.dart#newcode193 pkg/compiler/lib/src/js_backend/codegen/task.dart:193: if (cpsIntegrityChecker == null) { Is this worth ...
5 years, 2 months ago (2015-10-15 23:06:52 UTC) #3
asgerf
https://chromiumcodereview.appspot.com/1397953005/diff/1/pkg/compiler/lib/src/js_backend/codegen/task.dart File pkg/compiler/lib/src/js_backend/codegen/task.dart (right): https://chromiumcodereview.appspot.com/1397953005/diff/1/pkg/compiler/lib/src/js_backend/codegen/task.dart#newcode193 pkg/compiler/lib/src/js_backend/codegen/task.dart:193: if (cpsIntegrityChecker == null) { On 2015/10/15 23:06:52, sra1 ...
5 years, 2 months ago (2015-10-16 07:43:31 UTC) #4
asgerf
5 years, 2 months ago (2015-10-16 07:52:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e23ef0cbb1d50f3225a29eadaaf31ffd51b3cdc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698