|
|
Created:
7 years, 8 months ago by mrunal Modified:
7 years, 8 months ago CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionRemove the redundant declaration
PluginInstance was declared twice so removing redundant declaration
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195250
Patch Set 1 #Patch Set 2 : Remove the redundant declaration #Patch Set 3 : Remove the redundant declaration #Messages
Total messages: 17 (0 generated)
Hi Brett/Raymes, Above dependency might have got in when you approved previous patch, https://chromiumcodereview.appspot.com/11366038 I know it's a trivial patch but worth cleaning up I think. Mrunal
Sorry, I meant declaration and not dependency in my previous message.
I can't find you on the CLA signers list. Please see http://www.chromium.org/developers/contributing-code/external-contributor-che... with the links for signing. Thanks! On Wed, Apr 17, 2013 at 2:30 PM, <mrunal.kapade@intel.com> wrote: > Sorry, I meant declaration and not dependency in my previous message. > > https://codereview.chromium.org/13976005/
Hi Raymes, I should be there on corporation's(Intel) CLA if I'm right. On Apr 12th I was told by my internal source that CLA was signed for all contributions under @intel.com emails. Can you please check if my name is there under Intel's CLA? Thanks, Mrunal On 2013/04/18 21:12:56, raymes wrote: > I can't find you on the CLA signers list. Please see > http://www.chromium.org/developers/contributing-code/external-contributor-che... > with the links for signing. > > Thanks! > > On Wed, Apr 17, 2013 at 2:30 PM, <mailto:mrunal.kapade@intel.com> wrote: > > Sorry, I meant declaration and not dependency in my previous message. > > > > https://codereview.chromium.org/13976005/
You're right, sorry I didn't check the corporate list! lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/13976005/1
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file AUTHORS Hunk #1 FAILED at 233. 1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej Patch: AUTHORS Index: AUTHORS diff --git a/AUTHORS b/AUTHORS index 6c6622be0b5964eded1fea99aacf94ee27963608..24f40cb80ef40c24571342b22d5a9fdd40ede9fa 100644 --- a/AUTHORS +++ b/AUTHORS @@ -233,3 +233,4 @@ Sam Larison <qufighter@gmail.com> Jun Jiang <jun.a.jiang@intel.com> Bobby Powers <bobbypowers@gmail.com> Patrick Riordan <patrickriordan177@gmail.com> +Mrunal Kapade <mrunal.kapade@intel.com>
Don't understand what this error means. I checked the Commit box as per the instructions here, http://dev.chromium.org/developers/contributing-code#TOC-If-you-are-not-a-com... Do I need to rebase my patch with the latest revision? On 2013/04/18 22:32:10, I haz the power (commit-bot) wrote: > Failed to apply patch for AUTHORS: > While running patch -p1 --forward --force --no-backup-if-mismatch; > patching file AUTHORS > Hunk #1 FAILED at 233. > 1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej > > Patch: AUTHORS > Index: AUTHORS > diff --git a/AUTHORS b/AUTHORS > index > 6c6622be0b5964eded1fea99aacf94ee27963608..24f40cb80ef40c24571342b22d5a9fdd40ede9fa > 100644 > --- a/AUTHORS > +++ b/AUTHORS > @@ -233,3 +233,4 @@ Sam Larison <mailto:qufighter@gmail.com> > Jun Jiang <mailto:jun.a.jiang@intel.com> > Bobby Powers <mailto:bobbypowers@gmail.com> > Patrick Riordan <mailto:patrickriordan177@gmail.com> > +Mrunal Kapade <mailto:mrunal.kapade@intel.com>
Yes, please sync to the latest revision and rebase the patch. Then you can upload and commit again. On Thu, Apr 18, 2013 at 3:57 PM, <mrunal.kapade@intel.com> wrote: > Don't understand what this error means. I checked the Commit box as per the > instructions here, > http://dev.chromium.org/developers/contributing-code#TOC-If-you-are-not-a-com... > > Do I need to rebase my patch with the latest revision? > > > On 2013/04/18 22:32:10, I haz the power (commit-bot) wrote: >> >> Failed to apply patch for AUTHORS: >> While running patch -p1 --forward --force --no-backup-if-mismatch; >> patching file AUTHORS >> Hunk #1 FAILED at 233. >> 1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej > > >> Patch: AUTHORS >> Index: AUTHORS >> diff --git a/AUTHORS b/AUTHORS >> index > > > 6c6622be0b5964eded1fea99aacf94ee27963608..24f40cb80ef40c24571342b22d5a9fdd40ede9fa >> >> 100644 >> --- a/AUTHORS >> +++ b/AUTHORS >> @@ -233,3 +233,4 @@ Sam Larison <mailto:qufighter@gmail.com> >> Jun Jiang <mailto:jun.a.jiang@intel.com> >> Bobby Powers <mailto:bobbypowers@gmail.com> >> Patrick Riordan <mailto:patrickriordan177@gmail.com> >> +Mrunal Kapade <mailto:mrunal.kapade@intel.com> > > > > https://codereview.chromium.org/13976005/
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/13976005/10001
Presubmit check for 13976005-10001 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit commit checks ... Running /b/commit-queue/workdir/chromium/PRESUBMIT.py ** Presubmit Messages ** If this change has an associated bug, add BUG=[bug number]. ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: content/public/renderer/renderer_ppapi_host.h Presubmit checks took 3.4s to calculate.
So I need approval from Joi(owner) as well? Sorry for bugging you all for this trivial patch. :) This is my first time and it helps me understand your review process better. On 2013/04/18 23:34:20, I haz the power (commit-bot) wrote: > Presubmit check for 13976005-10001 failed and returned exit status 1. > > INFO:root:Found 2 file(s). > > Running presubmit commit checks ... > Running /b/commit-queue/workdir/chromium/PRESUBMIT.py > > ** Presubmit Messages ** > If this change has an associated bug, add BUG=[bug number]. > > ** Presubmit ERRORS ** > Missing LGTM from an OWNER for these files: > content/public/renderer/renderer_ppapi_host.h > > Presubmit checks took 3.4s to calculate.
LGTM
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/13976005/10001
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file AUTHORS Hunk #1 FAILED at 236. 1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej Patch: AUTHORS Index: AUTHORS diff --git a/AUTHORS b/AUTHORS index 2b48d4dca82b8238dce10354063bc176f57fcc19..7a01970324fdf3ae8bd8436f845be6e4256584f7 100644 --- a/AUTHORS +++ b/AUTHORS @@ -236,3 +236,4 @@ Patrick Riordan <patrickriordan177@gmail.com> Kenneth Rohde Christiansen <kenneth.r.christiansen@intel.com> Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Yandex LLC <*@yandex-team.ru> +Mrunal Kapade <mrunal.kapade@intel.com>
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/13976005/18001
Message was sent while issue was closed.
Change committed as 195250 |