Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 13976005: Remove the redundant declaration (Closed)

Created:
7 years, 8 months ago by mrunal
Modified:
7 years, 8 months ago
Reviewers:
brettw, raymes, Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the redundant declaration PluginInstance was declared twice so removing redundant declaration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195250

Patch Set 1 #

Patch Set 2 : Remove the redundant declaration #

Patch Set 3 : Remove the redundant declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/renderer/renderer_ppapi_host.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
mrunal
Hi Brett/Raymes, Above dependency might have got in when you approved previous patch, https://chromiumcodereview.appspot.com/11366038 I ...
7 years, 8 months ago (2013-04-17 21:25:28 UTC) #1
mrunal
Sorry, I meant declaration and not dependency in my previous message.
7 years, 8 months ago (2013-04-17 21:30:53 UTC) #2
raymes
I can't find you on the CLA signers list. Please see http://www.chromium.org/developers/contributing-code/external-contributor-checklist with the links ...
7 years, 8 months ago (2013-04-18 21:12:56 UTC) #3
mrunal
Hi Raymes, I should be there on corporation's(Intel) CLA if I'm right. On Apr 12th ...
7 years, 8 months ago (2013-04-18 21:47:08 UTC) #4
raymes
You're right, sorry I didn't check the corporate list! lgtm
7 years, 8 months ago (2013-04-18 22:01:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/13976005/1
7 years, 8 months ago (2013-04-18 22:32:09 UTC) #6
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-18 22:32:10 UTC) #7
mrunal
Don't understand what this error means. I checked the Commit box as per the instructions ...
7 years, 8 months ago (2013-04-18 22:57:57 UTC) #8
raymes
Yes, please sync to the latest revision and rebase the patch. Then you can upload ...
7 years, 8 months ago (2013-04-18 23:02:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/13976005/10001
7 years, 8 months ago (2013-04-18 23:34:14 UTC) #10
commit-bot: I haz the power
Presubmit check for 13976005-10001 failed and returned exit status 1. INFO:root:Found 2 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-18 23:34:20 UTC) #11
mrunal
So I need approval from Joi(owner) as well? Sorry for bugging you all for this ...
7 years, 8 months ago (2013-04-18 23:45:02 UTC) #12
Jói
LGTM
7 years, 8 months ago (2013-04-19 10:56:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/13976005/10001
7 years, 8 months ago (2013-04-19 16:36:35 UTC) #14
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-19 16:36:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/13976005/18001
7 years, 8 months ago (2013-04-19 16:45:40 UTC) #16
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 18:48:52 UTC) #17
Message was sent while issue was closed.
Change committed as 195250

Powered by Google App Engine
This is Rietveld 408576698