Rewrite PPB_AudioInput_Dev to use the new-style host/resource.

Rewrite PPB_AudioInput_Dev to use the new-style host/resource.

TEST=None
BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166777

[yzshen1, 2012-11-01 17:18:08]

Hi, Brett and Raymes.

Would you please take a look? Thanks!
I am very happy that the new code is much cleaner:
  718 insertions(+), 1603 deletions(-)

Raymes: details
Brett: OWNER and high-level ideas.

[raymes, 2012-11-02 16:04:02]

Hi Yuzhu,

Could please re-upload the patch. I see "error: old chunk mismatch"
when I try to view it.

Thanks,
Raymes

On Thu, Nov 1, 2012 at 10:18 AM,  <yzshen@chromium.org> wrote:
> Reviewers: brettw, raymes,
>
> Message:
> Hi, Brett and Raymes.
>
> Would you please take a look? Thanks!
> I am very happy that the new code is much cleaner:
>   718 insertions(+), 1603 deletions(-)
>
> Raymes: details
> Brett: OWNER and high-level ideas.
>
> Description:
> Rewrite PPB_AudioInput_Dev to use the new-style host/resource.
>
> TEST=None
> BUG=None
>
>
> Please review this at http://codereview.chromium.org/11366038/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M chrome/nacl/nacl_ipc_adapter.cc
>   M content/content_renderer.gypi
>   M content/public/renderer/renderer_ppapi_host.h
>   M content/renderer/pepper/content_renderer_pepper_host_factory.cc
>   A content/renderer/pepper/pepper_audio_input_host.h
>   A content/renderer/pepper/pepper_audio_input_host.cc
>   M content/renderer/pepper/renderer_ppapi_host_impl.h
>   M content/renderer/pepper/renderer_ppapi_host_impl.cc
>   M ppapi/api/dev/ppb_audio_input_dev.idl
>   D ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
>   M ppapi/c/dev/ppb_audio_input_dev.h
>   D ppapi/c/trusted/ppb_audio_input_trusted_dev.h
>   M ppapi/cpp/dev/audio_input_dev.h
>   M ppapi/cpp/dev/audio_input_dev.cc
>   M ppapi/examples/audio_input/audio_input.cc
>   M ppapi/examples/audio_input/audio_input.html
>   M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
>   M ppapi/ppapi_proxy.gypi
>   M ppapi/ppapi_shared.gypi
>   A ppapi/proxy/audio_input_resource.h
>   A + ppapi/proxy/audio_input_resource.cc
>   M ppapi/proxy/interface_list.cc
>   M ppapi/proxy/ppapi_messages.h
>   D ppapi/proxy/ppb_audio_input_proxy.h
>   D ppapi/proxy/ppb_audio_input_proxy.cc
>   M ppapi/proxy/proxy_channel.cc
>   M ppapi/proxy/resource_creation_proxy.h
>   M ppapi/proxy/resource_creation_proxy.cc
>   D ppapi/shared_impl/ppb_audio_input_shared.h
>   D ppapi/shared_impl/ppb_audio_input_shared.cc
>   M ppapi/shared_impl/resource.h
>   M ppapi/thunk/interfaces_ppb_public_dev.h
>   M ppapi/thunk/ppb_audio_input_api.h
>   M ppapi/thunk/ppb_audio_input_thunk.cc
>   D ppapi/thunk/ppb_audio_input_trusted_thunk.cc
>   M ppapi/thunk/resource_creation_api.h
>   M ppapi/thunk/thunk.h
>   M webkit/glue/webkit_glue.gypi
>   M webkit/plugins/ppapi/plugin_module.cc
>   D webkit/plugins/ppapi/ppb_audio_input_impl.h
>   D webkit/plugins/ppapi/ppb_audio_input_impl.cc
>   M webkit/plugins/ppapi/resource_creation_impl.h
>   M webkit/plugins/ppapi/resource_creation_impl.cc
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[raymes, 2012-11-02 16:04:02]

Hi Yuzhu,

Could please re-upload the patch. I see "error: old chunk mismatch"
when I try to view it.

Thanks,
Raymes

On Thu, Nov 1, 2012 at 10:18 AM,  <yzshen@chromium.org> wrote:
> Reviewers: brettw, raymes,
>
> Message:
> Hi, Brett and Raymes.
>
> Would you please take a look? Thanks!
> I am very happy that the new code is much cleaner:
>   718 insertions(+), 1603 deletions(-)
>
> Raymes: details
> Brett: OWNER and high-level ideas.
>
> Description:
> Rewrite PPB_AudioInput_Dev to use the new-style host/resource.
>
> TEST=None
> BUG=None
>
>
> Please review this at http://codereview.chromium.org/11366038/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M chrome/nacl/nacl_ipc_adapter.cc
>   M content/content_renderer.gypi
>   M content/public/renderer/renderer_ppapi_host.h
>   M content/renderer/pepper/content_renderer_pepper_host_factory.cc
>   A content/renderer/pepper/pepper_audio_input_host.h
>   A content/renderer/pepper/pepper_audio_input_host.cc
>   M content/renderer/pepper/renderer_ppapi_host_impl.h
>   M content/renderer/pepper/renderer_ppapi_host_impl.cc
>   M ppapi/api/dev/ppb_audio_input_dev.idl
>   D ppapi/api/trusted/ppb_audio_input_trusted_dev.idl
>   M ppapi/c/dev/ppb_audio_input_dev.h
>   D ppapi/c/trusted/ppb_audio_input_trusted_dev.h
>   M ppapi/cpp/dev/audio_input_dev.h
>   M ppapi/cpp/dev/audio_input_dev.cc
>   M ppapi/examples/audio_input/audio_input.cc
>   M ppapi/examples/audio_input/audio_input.html
>   M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
>   M ppapi/ppapi_proxy.gypi
>   M ppapi/ppapi_shared.gypi
>   A ppapi/proxy/audio_input_resource.h
>   A + ppapi/proxy/audio_input_resource.cc
>   M ppapi/proxy/interface_list.cc
>   M ppapi/proxy/ppapi_messages.h
>   D ppapi/proxy/ppb_audio_input_proxy.h
>   D ppapi/proxy/ppb_audio_input_proxy.cc
>   M ppapi/proxy/proxy_channel.cc
>   M ppapi/proxy/resource_creation_proxy.h
>   M ppapi/proxy/resource_creation_proxy.cc
>   D ppapi/shared_impl/ppb_audio_input_shared.h
>   D ppapi/shared_impl/ppb_audio_input_shared.cc
>   M ppapi/shared_impl/resource.h
>   M ppapi/thunk/interfaces_ppb_public_dev.h
>   M ppapi/thunk/ppb_audio_input_api.h
>   M ppapi/thunk/ppb_audio_input_thunk.cc
>   D ppapi/thunk/ppb_audio_input_trusted_thunk.cc
>   M ppapi/thunk/resource_creation_api.h
>   M ppapi/thunk/thunk.h
>   M webkit/glue/webkit_glue.gypi
>   M webkit/plugins/ppapi/plugin_module.cc
>   D webkit/plugins/ppapi/ppb_audio_input_impl.h
>   D webkit/plugins/ppapi/ppb_audio_input_impl.cc
>   M webkit/plugins/ppapi/resource_creation_impl.h
>   M webkit/plugins/ppapi/resource_creation_impl.cc
>
>

[raymes, 2012-11-04 20:59:59]

First pass. Looks good only a couple of nits.

http://codereview.chromium.org/11366038/diff/6002/content/renderer/pepper/pep...
File content/renderer/pepper/pepper_audio_input_host.cc (right):

http://codereview.chromium.org/11366038/diff/6002/content/renderer/pepper/pep...
content/renderer/pepper/pepper_audio_input_host.cc:36: #error "Platform not
supported."
Indentation - I think it should be 2 space indent or no space indent.

http://codereview.chromium.org/11366038/diff/6002/content/renderer/pepper/pep...
content/renderer/pepper/pepper_audio_input_host.cc:96:
base::Bind(&PepperAudioInputHost::EnumerateDevicesCallbackFunc,
Is it worth binding the replymessagecontext here? Is there a reason why two
requests can't be pending at the same time?

http://codereview.chromium.org/11366038/diff/6002/ppapi/proxy/audio_input_res...
File ppapi/proxy/audio_input_resource.cc (right):

http://codereview.chromium.org/11366038/diff/6002/ppapi/proxy/audio_input_res...
ppapi/proxy/audio_input_resource.cc:51: if (pending_enumerate_devices_)
Is only one request allowed to be in progress at a time?

[yzshen1, 2012-11-06 22:14:20]

http://codereview.chromium.org/11366038/diff/6002/content/renderer/pepper/pep...
File content/renderer/pepper/pepper_audio_input_host.cc (right):

http://codereview.chromium.org/11366038/diff/6002/content/renderer/pepper/pep...
content/renderer/pepper/pepper_audio_input_host.cc:36: #error "Platform not
supported."
On 2012/11/04 20:59:59, raymes wrote:
> Indentation - I think it should be 2 space indent or no space indent.

Done.

http://codereview.chromium.org/11366038/diff/6002/content/renderer/pepper/pep...
content/renderer/pepper/pepper_audio_input_host.cc:96:
base::Bind(&PepperAudioInputHost::EnumerateDevicesCallbackFunc,
On 2012/11/04 20:59:59, raymes wrote:
> Is it worth binding the replymessagecontext here?
I lean slightly towards the current way. (expression just learnt from you! :))
The lifespan is more clear.

> Is there a reason why two
> requests can't be pending at the same time?
No. I did it only the match the previous behavior. 

I don't have a very strong opinion about both issues, though. Please let me know
if you want me to change them.

http://codereview.chromium.org/11366038/diff/6002/ppapi/proxy/audio_input_res...
File ppapi/proxy/audio_input_resource.cc (right):

http://codereview.chromium.org/11366038/diff/6002/ppapi/proxy/audio_input_res...
ppapi/proxy/audio_input_resource.cc:51: if (pending_enumerate_devices_)
On 2012/11/04 20:59:59, raymes wrote:
> Is only one request allowed to be in progress at a time?

I did it to match the previous behavior.

[raymes, 2012-11-07 00:11:46]

lgtm

http://codereview.chromium.org/11366038/diff/12002/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

http://codereview.chromium.org/11366038/diff/12002/ppapi/proxy/ppapi_messages...
ppapi/proxy/ppapi_messages.h:1682:
IPC_MESSAGE_CONTROL0(PpapiPluginMsg_AudioInput_OpenReply)
In theory you don't even have to define this message type (you could just send
an empty message) but it's fine to be more explicit.

http://codereview.chromium.org/11366038/diff/12002/webkit/plugins/ppapi/resou...
File webkit/plugins/ppapi/resource_creation_impl.cc (right):

http://codereview.chromium.org/11366038/diff/12002/webkit/plugins/ppapi/resou...
webkit/plugins/ppapi/resource_creation_impl.cc:75: return 0;  // Not supported
in-process.
Maybe add NOTIMPLEMENTED() here?

[commit-bot: I haz the power, 2012-11-07 21:07:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/11366038/13001

[commit-bot: I haz the power, 2012-11-07 21:09:13]

Failed to apply patch for
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
  Hunk #1 FAILED at 3.
  Hunk #2 succeeded at 91 (offset 1 line).
  Hunk #3 succeeded at 150 (offset 1 line).
  Hunk #4 succeeded at 160 (offset 1 line).
  Hunk #5 succeeded at 1100 (offset 2 lines).
  Hunk #6 succeeded at 1278 (offset 2 lines).
  Hunk #7 succeeded at 3707 (offset 4 lines).
  Hunk #8 succeeded at 3758 (offset 4 lines).
  Hunk #9 succeeded at 4515 (offset 6 lines).
  Hunk #10 succeeded at 4575 (offset 6 lines).
  Hunk #11 succeeded at 5099 (offset 12 lines).
  Hunk #12 succeeded at 5109 (offset 12 lines).
  1 out of 12 hunks FAILED -- saving rejects to file
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c.rej

Patch:       ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
Index: ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
diff --git a/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
b/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
index
0346320126eb5ae267e60922653be441a5e62d2d..fb76fbde3a6b32b282077255172b24ddbd0bd6d3
100644
--- a/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
+++ b/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
@@ -3,7 +3,7 @@
  * found in the LICENSE file.
  */
 
-/* Last generated from IDL: Mon Oct 29 12:56:27 2012. */
+/* Last generated from IDL: Wed Nov  7 11:20:53 2012. */
 #include "ppapi/generators/pnacl_shim.h"
 
 #include "ppapi/c/ppb.h"
@@ -90,7 +90,6 @@
 #include "ppapi/c/private/ppp_content_decryptor_private.h"
 #include "ppapi/c/private/ppp_flash_browser_operations.h"
 #include "ppapi/c/private/ppp_instance_private.h"
-#include "ppapi/c/trusted/ppb_audio_input_trusted_dev.h"
 #include "ppapi/c/trusted/ppb_audio_trusted.h"
 #include "ppapi/c/trusted/ppb_broker_trusted.h"
 #include "ppapi/c/trusted/ppb_browser_font_trusted.h"
@@ -150,7 +149,6 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPP_Instance_1_0;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPP_Instance_1_1;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPP_Messaging_1_0;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPP_MouseLock_1_0;
-static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioTrusted_0_6;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_BrokerTrusted_0_2;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_BrowserFont_Trusted_1_0;
@@ -161,7 +159,6 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_FileChooserTrusted_0_6;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_FileIOTrusted_0_4;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_ImageDataTrusted_0_4;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_URLLoaderTrusted_0_3;
-static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_1;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_2;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Buffer_Dev_0_4;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Console_Dev_0_1;
@@ -1101,34 +1098,6 @@ static void
Pnacl_M14_PPP_Messaging_HandleMessage(PP_Instance instance, struct P
 
 /* Not generating wrapper methods for PPP_MouseLock_1_0 */
 
-/* Begin wrapper methods for PPB_AudioInputTrusted_Dev_0_1 */
-
-static __attribute__((pnaclcall))
-PP_Resource Pnacl_M17_PPB_AudioInputTrusted_Dev_CreateTrusted(PP_Instance
instance) {
-  const struct PPB_AudioInputTrusted_Dev_0_1 *iface =
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1.real_iface;
-  return iface->CreateTrusted(instance);
-}
-
-static __attribute__((pnaclcall))
-int32_t Pnacl_M17_PPB_AudioInputTrusted_Dev_Open(PP_Resource audio_input,
PP_Resource config, struct PP_CompletionCallback create_callback) {
-  const struct PPB_AudioInputTrusted_Dev_0_1 *iface =
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1.real_iface;
-  return iface->Open(audio_input, config, create_callback);
-}
-
-static __attribute__((pnaclcall))
-int32_t Pnacl_M17_PPB_AudioInputTrusted_Dev_GetSyncSocket(PP_Resource
audio_input, int* sync_socket) {
-  const struct PPB_AudioInputTrusted_Dev_0_1 *iface =
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1.real_iface;
-  return iface->GetSyncSocket(audio_input, sync_socket);
-}
-
-static __attribute__((pnaclcall))
-int32_t Pnacl_M17_PPB_AudioInputTrusted_Dev_GetSharedMemory(PP_Resource
audio_input, int* shm_handle, uint32_t* shm_size) {
-  const struct PPB_AudioInputTrusted_Dev_0_1 *iface =
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1.real_iface;
-  return iface->GetSharedMemory(audio_input, shm_handle, shm_size);
-}
-
-/* End wrapper methods for PPB_AudioInputTrusted_Dev_0_1 */
-
 /* Begin wrapper methods for PPB_AudioTrusted_0_6 */
 
 static __attribute__((pnaclcall))
@@ -1307,8 +1276,6 @@ int32_t
Pnacl_M14_PPB_FileIOTrusted_WillSetLength(PP_Resource file_io, int64_t l
 
 /* Not generating wrapper methods for PPB_URLLoaderTrusted_0_3 */
 
-/* Not generating wrapper methods for PPB_AudioInput_Dev_0_1 */
-
 /* Begin wrapper methods for PPB_AudioInput_Dev_0_2 */
 
 static __attribute__((pnaclcall))
@@ -3736,13 +3703,6 @@ struct PPP_Messaging_1_0 Pnacl_Wrappers_PPP_Messaging_1_0
= {
 
 /* Not generating wrapper interface for PPP_MouseLock_1_0 */
 
-struct PPB_AudioInputTrusted_Dev_0_1
Pnacl_Wrappers_PPB_AudioInputTrusted_Dev_0_1 = {
-    .CreateTrusted = (PP_Resource (*)(PP_Instance
instance))&Pnacl_M17_PPB_AudioInputTrusted_Dev_CreateTrusted,
-    .Open = (int32_t (*)(PP_Resource audio_input, PP_Resource config, struct
PP_CompletionCallback
create_callback))&Pnacl_M17_PPB_AudioInputTrusted_Dev_Open,
-    .GetSyncSocket = (int32_t (*)(PP_Resource audio_input, int*
sync_socket))&Pnacl_M17_PPB_AudioInputTrusted_Dev_GetSyncSocket,
-    .GetSharedMemory = (int32_t (*)(PP_Resource audio_input, int* shm_handle,
uint32_t* shm_size))&Pnacl_M17_PPB_AudioInputTrusted_Dev_GetSharedMemory
-};
-
 struct PPB_AudioTrusted_0_6 Pnacl_Wrappers_PPB_AudioTrusted_0_6 = {
     .CreateTrusted = (PP_Resource (*)(PP_Instance
instance))&Pnacl_M14_PPB_AudioTrusted_CreateTrusted,
     .Open = (int32_t (*)(PP_Resource audio, PP_Resource config, struct
PP_CompletionCallback create_callback))&Pnacl_M14_PPB_AudioTrusted_Open,
@@ -3794,8 +3754,6 @@ struct PPB_FileIOTrusted_0_4
Pnacl_Wrappers_PPB_FileIOTrusted_0_4 = {
 
 /* Not generating wrapper interface for PPB_URLLoaderTrusted_0_3 */
 
-/* Not generating wrapper interface for PPB_AudioInput_Dev_0_1 */
-
 struct PPB_AudioInput_Dev_0_2 Pnacl_Wrappers_PPB_AudioInput_Dev_0_2 = {
     .Create = (PP_Resource (*)(PP_Instance
instance))&Pnacl_M19_PPB_AudioInput_Dev_Create,
     .IsAudioInput = (PP_Bool (*)(PP_Resource
resource))&Pnacl_M19_PPB_AudioInput_Dev_IsAudioInput,
@@ -4551,12 +4509,6 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPP_MouseLock_1_0 = {
   .real_iface = NULL
 };
 
-static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1 = {
-  .iface_macro = PPB_AUDIO_INPUT_TRUSTED_DEV_INTERFACE_0_1,
-  .wrapped_iface = (void *) &Pnacl_Wrappers_PPB_AudioInputTrusted_Dev_0_1,
-  .real_iface = NULL
-};
-
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioTrusted_0_6 = {
   .iface_macro = PPB_AUDIO_TRUSTED_INTERFACE_0_6,
   .wrapped_iface = (void *) &Pnacl_Wrappers_PPB_AudioTrusted_0_6,
@@ -4617,12 +4569,6 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_URLLoaderTrusted_0_3 = {
   .real_iface = NULL
 };
 
-static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_1 = {
-  .iface_macro = PPB_AUDIO_INPUT_DEV_INTERFACE_0_1,
-  .wrapped_iface = NULL /* Still need slot for real_iface */,
-  .real_iface = NULL
-};
-
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_2 = {
   .iface_macro = PPB_AUDIO_INPUT_DEV_INTERFACE_0_2,
   .wrapped_iface = (void *) &Pnacl_Wrappers_PPB_AudioInput_Dev_0_2,
@@ -5141,7 +5087,6 @@ static struct __PnaclWrapperInfo *s_ppb_wrappers[] = {
   &Pnacl_WrapperInfo_PPB_VarArrayBuffer_1_0,
   &Pnacl_WrapperInfo_PPB_View_1_0,
   &Pnacl_WrapperInfo_PPB_WebSocket_1_0,
-  &Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1,
   &Pnacl_WrapperInfo_PPB_AudioTrusted_0_6,
   &Pnacl_WrapperInfo_PPB_BrokerTrusted_0_2,
   &Pnacl_WrapperInfo_PPB_BrowserFont_Trusted_1_0,
@@ -5152,7 +5097,6 @@ static struct __PnaclWrapperInfo *s_ppb_wrappers[] = {
   &Pnacl_WrapperInfo_PPB_FileIOTrusted_0_4,
   &Pnacl_WrapperInfo_PPB_ImageDataTrusted_0_4,
   &Pnacl_WrapperInfo_PPB_URLLoaderTrusted_0_3,
-  &Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_1,
   &Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_2,
   &Pnacl_WrapperInfo_PPB_Buffer_Dev_0_4,
   &Pnacl_WrapperInfo_PPB_Console_Dev_0_1,

[brettw, 2012-11-08 00:20:32]

lgtm

http://codereview.chromium.org/11366038/diff/13001/ppapi/proxy/audio_input_re...
File ppapi/proxy/audio_input_resource.cc (right):

http://codereview.chromium.org/11366038/diff/13001/ppapi/proxy/audio_input_re...
ppapi/proxy/audio_input_resource.cc:274: } // namespace proxy
Nit: 2 spaces before //

[yzshen1, 2012-11-08 18:57:30]

Thanks!

http://codereview.chromium.org/11366038/diff/12002/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

http://codereview.chromium.org/11366038/diff/12002/ppapi/proxy/ppapi_messages...
ppapi/proxy/ppapi_messages.h:1682:
IPC_MESSAGE_CONTROL0(PpapiPluginMsg_AudioInput_OpenReply)
On 2012/11/07 00:11:46, raymes wrote:
> In theory you don't even have to define this message type (you could just send
> an empty message) but it's fine to be more explicit.

Yeah, I think it is good to be explicit. :)

http://codereview.chromium.org/11366038/diff/12002/webkit/plugins/ppapi/resou...
File webkit/plugins/ppapi/resource_creation_impl.cc (right):

http://codereview.chromium.org/11366038/diff/12002/webkit/plugins/ppapi/resou...
webkit/plugins/ppapi/resource_creation_impl.cc:75: return 0;  // Not supported
in-process.
On 2012/11/07 00:11:46, raymes wrote:
> Maybe add NOTIMPLEMENTED() here?

As we discussed, NOTIMPLEMENTED() is for something that haven't been implemented
*yet*, instead of something that we are not going to implement.

http://codereview.chromium.org/11366038/diff/13001/ppapi/proxy/audio_input_re...
File ppapi/proxy/audio_input_resource.cc (right):

http://codereview.chromium.org/11366038/diff/13001/ppapi/proxy/audio_input_re...
ppapi/proxy/audio_input_resource.cc:274: } // namespace proxy
On 2012/11/08 00:20:32, brettw wrote:
> Nit: 2 spaces before //

Done.

[commit-bot: I haz the power, 2012-11-08 18:58:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/11366038/6047

[commit-bot: I haz the power, 2012-11-08 18:58:45]

Failed to apply patch for
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
  Hunk #1 FAILED at 3.
  1 out of 12 hunks FAILED -- saving rejects to file
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c.rej

Patch:       ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
Index: ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
diff --git a/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
b/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
index
9c6360891add7e92b65f48088c2468802b60bc2b..5809037116124cb2c95ae090890d3977d3681b36
100644
--- a/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
+++ b/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
@@ -3,7 +3,7 @@
  * found in the LICENSE file.
  */
 
-/* Last generated from IDL: Wed Nov  7 13:45:01 2012. */
+/* Last generated from IDL: Thu Nov  8 10:55:53 2012. */
 #include "ppapi/generators/pnacl_shim.h"
 
 #include "ppapi/c/ppb.h"
@@ -92,7 +92,6 @@
 #include "ppapi/c/private/ppp_content_decryptor_private.h"
 #include "ppapi/c/private/ppp_flash_browser_operations.h"
 #include "ppapi/c/private/ppp_instance_private.h"
-#include "ppapi/c/trusted/ppb_audio_input_trusted_dev.h"
 #include "ppapi/c/trusted/ppb_audio_trusted.h"
 #include "ppapi/c/trusted/ppb_broker_trusted.h"
 #include "ppapi/c/trusted/ppb_browser_font_trusted.h"
@@ -152,7 +151,6 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPP_Instance_1_0;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPP_Instance_1_1;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPP_Messaging_1_0;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPP_MouseLock_1_0;
-static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioTrusted_0_6;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_BrokerTrusted_0_2;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_BrowserFont_Trusted_1_0;
@@ -163,7 +161,6 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_FileChooserTrusted_0_6;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_FileIOTrusted_0_4;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_ImageDataTrusted_0_4;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_URLLoaderTrusted_0_3;
-static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_1;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_2;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Buffer_Dev_0_4;
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_Console_Dev_0_1;
@@ -1105,34 +1102,6 @@ static void
Pnacl_M14_PPP_Messaging_HandleMessage(PP_Instance instance, struct P
 
 /* Not generating wrapper methods for PPP_MouseLock_1_0 */
 
-/* Begin wrapper methods for PPB_AudioInputTrusted_Dev_0_1 */
-
-static __attribute__((pnaclcall))
-PP_Resource Pnacl_M17_PPB_AudioInputTrusted_Dev_CreateTrusted(PP_Instance
instance) {
-  const struct PPB_AudioInputTrusted_Dev_0_1 *iface =
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1.real_iface;
-  return iface->CreateTrusted(instance);
-}
-
-static __attribute__((pnaclcall))
-int32_t Pnacl_M17_PPB_AudioInputTrusted_Dev_Open(PP_Resource audio_input,
PP_Resource config, struct PP_CompletionCallback create_callback) {
-  const struct PPB_AudioInputTrusted_Dev_0_1 *iface =
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1.real_iface;
-  return iface->Open(audio_input, config, create_callback);
-}
-
-static __attribute__((pnaclcall))
-int32_t Pnacl_M17_PPB_AudioInputTrusted_Dev_GetSyncSocket(PP_Resource
audio_input, int* sync_socket) {
-  const struct PPB_AudioInputTrusted_Dev_0_1 *iface =
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1.real_iface;
-  return iface->GetSyncSocket(audio_input, sync_socket);
-}
-
-static __attribute__((pnaclcall))
-int32_t Pnacl_M17_PPB_AudioInputTrusted_Dev_GetSharedMemory(PP_Resource
audio_input, int* shm_handle, uint32_t* shm_size) {
-  const struct PPB_AudioInputTrusted_Dev_0_1 *iface =
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1.real_iface;
-  return iface->GetSharedMemory(audio_input, shm_handle, shm_size);
-}
-
-/* End wrapper methods for PPB_AudioInputTrusted_Dev_0_1 */
-
 /* Begin wrapper methods for PPB_AudioTrusted_0_6 */
 
 static __attribute__((pnaclcall))
@@ -1311,8 +1280,6 @@ int32_t
Pnacl_M14_PPB_FileIOTrusted_WillSetLength(PP_Resource file_io, int64_t l
 
 /* Not generating wrapper methods for PPB_URLLoaderTrusted_0_3 */
 
-/* Not generating wrapper methods for PPB_AudioInput_Dev_0_1 */
-
 /* Begin wrapper methods for PPB_AudioInput_Dev_0_2 */
 
 static __attribute__((pnaclcall))
@@ -3744,13 +3711,6 @@ struct PPP_Messaging_1_0 Pnacl_Wrappers_PPP_Messaging_1_0
= {
 
 /* Not generating wrapper interface for PPP_MouseLock_1_0 */
 
-struct PPB_AudioInputTrusted_Dev_0_1
Pnacl_Wrappers_PPB_AudioInputTrusted_Dev_0_1 = {
-    .CreateTrusted = (PP_Resource (*)(PP_Instance
instance))&Pnacl_M17_PPB_AudioInputTrusted_Dev_CreateTrusted,
-    .Open = (int32_t (*)(PP_Resource audio_input, PP_Resource config, struct
PP_CompletionCallback
create_callback))&Pnacl_M17_PPB_AudioInputTrusted_Dev_Open,
-    .GetSyncSocket = (int32_t (*)(PP_Resource audio_input, int*
sync_socket))&Pnacl_M17_PPB_AudioInputTrusted_Dev_GetSyncSocket,
-    .GetSharedMemory = (int32_t (*)(PP_Resource audio_input, int* shm_handle,
uint32_t* shm_size))&Pnacl_M17_PPB_AudioInputTrusted_Dev_GetSharedMemory
-};
-
 struct PPB_AudioTrusted_0_6 Pnacl_Wrappers_PPB_AudioTrusted_0_6 = {
     .CreateTrusted = (PP_Resource (*)(PP_Instance
instance))&Pnacl_M14_PPB_AudioTrusted_CreateTrusted,
     .Open = (int32_t (*)(PP_Resource audio, PP_Resource config, struct
PP_CompletionCallback create_callback))&Pnacl_M14_PPB_AudioTrusted_Open,
@@ -3802,8 +3762,6 @@ struct PPB_FileIOTrusted_0_4
Pnacl_Wrappers_PPB_FileIOTrusted_0_4 = {
 
 /* Not generating wrapper interface for PPB_URLLoaderTrusted_0_3 */
 
-/* Not generating wrapper interface for PPB_AudioInput_Dev_0_1 */
-
 struct PPB_AudioInput_Dev_0_2 Pnacl_Wrappers_PPB_AudioInput_Dev_0_2 = {
     .Create = (PP_Resource (*)(PP_Instance
instance))&Pnacl_M19_PPB_AudioInput_Dev_Create,
     .IsAudioInput = (PP_Bool (*)(PP_Resource
resource))&Pnacl_M19_PPB_AudioInput_Dev_IsAudioInput,
@@ -4563,12 +4521,6 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPP_MouseLock_1_0 = {
   .real_iface = NULL
 };
 
-static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1 = {
-  .iface_macro = PPB_AUDIO_INPUT_TRUSTED_DEV_INTERFACE_0_1,
-  .wrapped_iface = (void *) &Pnacl_Wrappers_PPB_AudioInputTrusted_Dev_0_1,
-  .real_iface = NULL
-};
-
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioTrusted_0_6 = {
   .iface_macro = PPB_AUDIO_TRUSTED_INTERFACE_0_6,
   .wrapped_iface = (void *) &Pnacl_Wrappers_PPB_AudioTrusted_0_6,
@@ -4629,12 +4581,6 @@ static struct __PnaclWrapperInfo
Pnacl_WrapperInfo_PPB_URLLoaderTrusted_0_3 = {
   .real_iface = NULL
 };
 
-static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_1 = {
-  .iface_macro = PPB_AUDIO_INPUT_DEV_INTERFACE_0_1,
-  .wrapped_iface = NULL /* Still need slot for real_iface */,
-  .real_iface = NULL
-};
-
 static struct __PnaclWrapperInfo Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_2 = {
   .iface_macro = PPB_AUDIO_INPUT_DEV_INTERFACE_0_2,
   .wrapped_iface = (void *) &Pnacl_Wrappers_PPB_AudioInput_Dev_0_2,
@@ -5165,7 +5111,6 @@ static struct __PnaclWrapperInfo *s_ppb_wrappers[] = {
   &Pnacl_WrapperInfo_PPB_VarArrayBuffer_1_0,
   &Pnacl_WrapperInfo_PPB_View_1_0,
   &Pnacl_WrapperInfo_PPB_WebSocket_1_0,
-  &Pnacl_WrapperInfo_PPB_AudioInputTrusted_Dev_0_1,
   &Pnacl_WrapperInfo_PPB_AudioTrusted_0_6,
   &Pnacl_WrapperInfo_PPB_BrokerTrusted_0_2,
   &Pnacl_WrapperInfo_PPB_BrowserFont_Trusted_1_0,
@@ -5176,7 +5121,6 @@ static struct __PnaclWrapperInfo *s_ppb_wrappers[] = {
   &Pnacl_WrapperInfo_PPB_FileIOTrusted_0_4,
   &Pnacl_WrapperInfo_PPB_ImageDataTrusted_0_4,
   &Pnacl_WrapperInfo_PPB_URLLoaderTrusted_0_3,
-  &Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_1,
   &Pnacl_WrapperInfo_PPB_AudioInput_Dev_0_2,
   &Pnacl_WrapperInfo_PPB_Buffer_Dev_0_4,
   &Pnacl_WrapperInfo_PPB_Console_Dev_0_1,

[commit-bot: I haz the power, 2012-11-08 19:19:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/11366038/48

[commit-bot: I haz the power, 2012-11-08 19:31:34]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-08 20:30:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/11366038/2007

[commit-bot: I haz the power, 2012-11-08 22:20:25]

Change committed as 166777