Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1397043003: Fix emission of move immediate for ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | src/IceAssemblerARM32.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/DartARM32/assembler_arm.h
diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h
index 7893d6f940fbea86719982433bfa3055340833dd..5790824128aef31a880682547b087d353f12bef8 100644
--- a/src/DartARM32/assembler_arm.h
+++ b/src/DartARM32/assembler_arm.h
@@ -139,12 +139,15 @@ class Operand : public ValueObject {
encoding_ = immediate;
}
+#if 0
+ // Moved to AssemblerARM32::encodeImm12FromFlexImm.
// Data-processing operands - Rotated immediate.
Operand(uint32_t rotate, uint32_t immed8) {
ASSERT((rotate < (1 << kRotateBits)) && (immed8 < (1 << kImmed8Bits)));
type_ = 1;
encoding_ = (rotate << kRotateShift) | (immed8 << kImmed8Shift);
}
+#endif
// Data-processing operands - Register.
explicit Operand(Register rm) {
@@ -465,7 +468,11 @@ class Assembler : public ValueObject {
void orr(Register rd, Register rn, Operand o, Condition cond = AL);
void orrs(Register rd, Register rn, Operand o, Condition cond = AL);
+#if 0
+ // Moved to IceAssemblerARM32::mov(..FlexImm..)
+ // TODO(kschimpf) other forms of move.
void mov(Register rd, Operand o, Condition cond = AL);
+#endif
void movs(Register rd, Operand o, Condition cond = AL);
void bic(Register rd, Register rn, Operand o, Condition cond = AL);
@@ -1084,6 +1091,8 @@ class Assembler : public ValueObject {
bool is_unique,
Register pp);
+#if 0
+ // Moved to class AssemblerARM32.
void EmitType01(Condition cond,
int type,
Opcode opcode,
@@ -1091,6 +1100,7 @@ class Assembler : public ValueObject {
Register rn,
Register rd,
Operand o);
+#endif
void EmitType5(Condition cond, int32_t offset, bool link);
« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | src/IceAssemblerARM32.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698