Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1396603003: Small improvements to api.platforms.android. (Closed)

Created:
5 years, 2 months ago by M-A Ruel
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, jbudorick
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Small improvements to api.platforms.android. - Save the adb RSA keys, the public part will be pushed later. - Stop silently ignoring broken RSA keys. - Stop accepting dual call to android.initialize(). - Remove CpuScalingGovernor and use the actual string instead. It will be used to verify against the ones published by the device's kernel in a follow up. R=stip@chromium.org BUG=chromium:525873 Committed: https://github.com/luci/luci-py/commit/6274d54e173c4bf8875a97db47212ba927a6d9e8

Patch Set 1 : . #

Patch Set 2 : Fix race condition in kill_adb() #

Patch Set 3 : Refuse multiple calls to initialize() and stop dropping broken keys silently #

Total comments: 3

Patch Set 4 : Trimmed down #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -42 lines) Patch
M appengine/swarming/swarming_bot/api/platforms/android.py View 1 2 3 6 chunks +41 lines, -42 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
Marc-Antoine Ruel (Google)
Starting to see the light at the end of the tunnel, the bots are now ...
5 years, 2 months ago (2015-10-08 02:06:11 UTC) #4
ghost stip (do not use)
these should have been sharded into separate CLs. review latency is your bottleneck, and that ...
5 years, 2 months ago (2015-10-08 20:13:29 UTC) #8
M-A Ruel
Trimmed the CL down.
5 years, 2 months ago (2015-10-13 17:30:34 UTC) #12
ghost stip (do not use)
lgtm
5 years, 2 months ago (2015-10-13 21:06:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1396603003/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1396603003/190001
5 years, 2 months ago (2015-10-14 06:56:35 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 06:58:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:190001) as
https://github.com/luci/luci-py/commit/6274d54e173c4bf8875a97db47212ba927a6d9e8

Powered by Google App Engine
This is Rietveld 408576698