Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1395583002: Propagate attributes from global to process memory allocator dumps (Closed)

Created:
5 years, 2 months ago by petrcermak
Modified:
5 years, 2 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org, ssid
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Propagate attributes from global to process memory allocator dumps This patch modifies the Memory infrastructure to copy attributes from MemoryAllocatorDump(s) in the global space to their owner MemoryAllocatorDump(s) in individual processes. Rationale: Chrome's browser process is able to get the resident memory of each segment of discardable memory from the system. The renderer processes cannot do this (even though they actually use the segments) because of the sandbox. By propagating attributes from the global memory allocator dumps (created by the browser) to the process memory allocator dumps (created by the renderers), we make this information available in the memory allocator dumps from the renderer. BUG=#1461 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/2aefd8d3797189dc00b97d254f21e3b74a481b1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -13 lines) Patch
M tracing/tracing/extras/importer/trace_event_importer_test.html View 2 chunks +4 lines, -2 lines 0 comments Download
M tracing/tracing/model/container_memory_dump.html View 1 chunk +6 lines, -0 lines 0 comments Download
M tracing/tracing/model/container_memory_dump_test.html View 1 chunk +17 lines, -0 lines 0 comments Download
M tracing/tracing/model/global_memory_dump.html View 5 chunks +42 lines, -8 lines 0 comments Download
M tracing/tracing/model/global_memory_dump_test.html View 6 chunks +99 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
petrcermak
Hi, Please review this patch. Thanks, Petr
5 years, 2 months ago (2015-10-07 17:29:12 UTC) #3
Primiano Tucci (use gerrit)
Awesome thanks LGTM I'd probably expand a bit the commit message with a simple example ...
5 years, 2 months ago (2015-10-07 17:34:53 UTC) #4
petrcermak
Thanks for your comments. Somehow I knew you'd ask for that. Petr
5 years, 2 months ago (2015-10-07 17:43:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395583002/20001
5 years, 2 months ago (2015-10-07 17:44:28 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 17:51:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698