Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tracing/tracing/extras/importer/trace_event_importer_test.html

Issue 1395583002: Propagate attributes from global to process memory allocator dumps (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tracing/tracing/model/container_memory_dump.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/extras/importer/trace_event_importer_test.html
diff --git a/tracing/tracing/extras/importer/trace_event_importer_test.html b/tracing/tracing/extras/importer/trace_event_importer_test.html
index b68a218deb562b1fb30d507e60e989727299850b..802dbdf08beba4700b5d68cc586926eddb7a7965 100644
--- a/tracing/tracing/extras/importer/trace_event_importer_test.html
+++ b/tracing/tracing/extras/importer/trace_event_importer_test.html
@@ -3532,7 +3532,8 @@ tr.b.unittest.testSuite(function() {
assert.isDefined(browserDumpLocal);
assert.include(browserDump.memoryAllocatorDumps, browserDumpLocal);
assert.equal(browserDumpLocal.attributes['mood'].value, 'very good');
- assert.isUndefined(browserDumpLocal.attributes['color']);
+ assert.equal(browserDumpLocal.attributes['area'].value, 9);
+ assert.equal(browserDumpLocal.attributes['color'].value, 'blue');
assert.lengthOf(browserDumpLocal.children, 0);
assert.isUndefined(browserDumpLocal.parent);
@@ -3555,7 +3556,8 @@ tr.b.unittest.testSuite(function() {
assert.isDefined(rendererDumpLocal);
assert.include(rendererDump.memoryAllocatorDumps, rendererDumpLocal);
assert.equal(rendererDumpLocal.attributes['length'].value, 3);
- assert.isUndefined(rendererDumpLocal.attributes['area']);
+ assert.equal(rendererDumpLocal.attributes['area'].value, 9);
+ assert.equal(rendererDumpLocal.attributes['color'].value, 'blue');
assert.lengthOf(rendererDumpLocal.children, 0);
assert.isUndefined(rendererDumpLocal.parent);
« no previous file with comments | « no previous file | tracing/tracing/model/container_memory_dump.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698