Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13954014: Add Supported class to dart:html (Closed)

Created:
7 years, 8 months ago by vsm
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add Supported class to dart:html This is only used by typeddata for now. Committed: https://code.google.com/p/dart/source/detail?r=21717

Patch Set 1 #

Total comments: 1

Patch Set 2 : Moved to Platform.supportsTypedData #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -27 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +8 lines, -3 lines 0 comments Download
M tests/html/transferables_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_1_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_3_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_4_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_5_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_arraybuffer_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_dataview_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_range_checks_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xhr_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/dom/src/dart2js_Platform.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
A + tools/dom/src/dartium_Platform.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsm
https://chromiumcodereview.appspot.com/13954014/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://chromiumcodereview.appspot.com/13954014/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#oldcode417 sdk/lib/html/dart2js/html_dart2js.dart:417: - static bool get supported => JS('bool', 'typeof window.ArrayBuffer ...
7 years, 8 months ago (2013-04-18 20:09:15 UTC) #1
vsm
PTAL: Supported -> Platform after chatting with Pete.
7 years, 8 months ago (2013-04-18 20:50:31 UTC) #2
Mads Ager (google)
LGTM
7 years, 8 months ago (2013-04-19 05:20:47 UTC) #3
vsm
7 years, 8 months ago (2013-04-19 05:54:13 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r21717 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698