Issue 13949015: Supporting multiple keyboard layouts.

Issue 13949015: Supporting multiple keyboard layouts. (Closed)

Created:
7 years, 8 months ago by Seigo Nonaka

Modified:
7 years, 8 months ago

Reviewers:
Nikita (slow), satorux1

CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Supporting multiple keyboard layouts. Before starting InputMethodDescription refactoring, let me add multiple keyboard layout support. BUG=170601 TEST=ran unit_tests and chromeos_unittests and also checked manually there is no regression around keyboard selection. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195931

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Addressing comment #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -61 lines)			Patch
M	chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View		4 chunks	+8 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/mock_input_method_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/cros_language_options_handler_unittest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chromeos/ime/component_extension_ime_manager.h	View		3 chunks	+13 lines, -3 lines	0 comments	Download
M	chromeos/ime/component_extension_ime_manager.cc	View		6 chunks	+12 lines, -6 lines	0 comments	Download
M	chromeos/ime/component_extension_ime_manager_unittest.cc	View		4 chunks	+19 lines, -19 lines	0 comments	Download
M	chromeos/ime/input_method_descriptor.h	View		1 chunk	+13 lines, -5 lines	0 comments	Download
M	chromeos/ime/input_method_descriptor.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	chromeos/ime/input_method_whitelist.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

satorux1

LGTM with a nit https://codereview.chromium.org/13949015/diff/13001/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h File chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h (right): https://codereview.chromium.org/13949015/diff/13001/chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h#newcode71 chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h:71: // otherwise retrun false. This ...

7 years, 8 months ago (2013-04-23 01:43:24 UTC) #2

Seigo Nonaka

Satoru, Thank you for your review! Adding Nikita as the owner of c/b/ui/webui/options/chromeos/ Nikita, could ...

7 years, 8 months ago (2013-04-23 01:50:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/13949015/19001

7 years, 8 months ago (2013-04-23 17:31:45 UTC) #5

Message was sent while issue was closed.

Change committed as 195931

Expand Messages | Collapse Messages