Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.cc

Issue 13949015: Supporting multiple keyboard layouts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comment Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_util.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_util.cc b/chrome/browser/chromeos/input_method/input_method_util.cc
index 892323594019e59139af802286ee5766274b23e1..f9136a012bc4c26175bb43849122670fc19d2514 100644
--- a/chrome/browser/chromeos/input_method/input_method_util.cc
+++ b/chrome/browser/chromeos/input_method/input_method_util.cc
@@ -362,7 +362,7 @@ std::string InputMethodUtil::GetKeyboardLayoutName(
InputMethodIdToDescriptorMap::const_iterator iter
= id_to_descriptor_.find(input_method_id);
return (iter == id_to_descriptor_.end()) ?
- "" : iter->second.keyboard_layout();
+ "" : iter->second.GetPreferredKeyboardLayout();
}
std::string InputMethodUtil::GetInputMethodDisplayNameFromId(
@@ -557,8 +557,8 @@ void InputMethodUtil::GetFirstLoginInputMethodIds(
GetInputMethodDescriptorFromId(input_method_id);
if (descriptor &&
descriptor->id() != current_input_method.id() &&
- descriptor->keyboard_layout() ==
- current_input_method.keyboard_layout()) {
+ descriptor->GetPreferredKeyboardLayout() ==
+ current_input_method.GetPreferredKeyboardLayout()) {
most_popular_id = input_method_id;
break;
}
@@ -620,9 +620,11 @@ void InputMethodUtil::SetComponentExtensions(
}
InputMethodDescriptor InputMethodUtil::GetFallbackInputMethodDescriptor() {
+ std::vector<std::string> layouts;
+ layouts.push_back("us");
return InputMethodDescriptor("xkb:us::eng",
"",
- "us",
+ layouts,
"en-US",
""); // options page, not available.
}
@@ -652,7 +654,8 @@ void InputMethodUtil::ReloadInternalMaps() {
std::make_pair(input_method.id(), input_method));
if (IsKeyboardLayout(input_method.id())) {
xkb_id_to_descriptor_.insert(
- std::make_pair(input_method.keyboard_layout(), input_method));
+ std::make_pair(input_method.GetPreferredKeyboardLayout(),
+ input_method));
}
}

Powered by Google App Engine
This is Rietveld 408576698