Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9309)

Unified Diff: chrome/common/extensions/permissions/permissions_data.cc

Issue 13947050: Stop forcing optional permission on usbDevices section (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove APIPermissionInfo::kFlagMustBeOptional and related tests. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permissions_data.cc
diff --git a/chrome/common/extensions/permissions/permissions_data.cc b/chrome/common/extensions/permissions/permissions_data.cc
index 5fba98398e17fb958ae40be5535b49badb42b42d..8e964daf27bd4e670d450c2eedd2400ef605728e 100644
--- a/chrome/common/extensions/permissions/permissions_data.cc
+++ b/chrome/common/extensions/permissions/permissions_data.cc
@@ -592,17 +592,6 @@ bool PermissionsData::ParsePermissions(Extension* extension, string16* error) {
return false;
}
- // Check for any permissions that are optional only.
- for (APIPermissionSet::const_iterator iter =
- initial_required_permissions_->api_permissions.begin();
- iter != initial_required_permissions_->api_permissions.end(); ++iter) {
- if ((*iter)->info()->must_be_optional()) {
- *error = ErrorUtils::FormatErrorMessageUTF16(
- errors::kPermissionMustBeOptional, (*iter)->info()->name());
- return false;
- }
- }
-
// TODO(jeremya/kalman) do this via the features system by exposing the
// app.window API to platform apps, with no dependency on any permissions.
// See http://crbug.com/120069.

Powered by Google App Engine
This is Rietveld 408576698