chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 13947050: Stop forcing optional permission on usbDevices section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 13947050: Stop forcing optional permission on usbDevices section (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove APIPermissionInfo::kFlagMustBeOptional and related tests. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index 5c7e5f56450d74db7165aa7c9b07ac95bf32d152..37f4a47ed8d816eef8712dc4dfbf0c5fb6c561e1 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -251,7 +251,7 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

IDS_EXTENSION_PROMPT_WARNING_USB,

PermissionMessage::kUsb },

{ APIPermission::kUsbDevice, "usbDevices",

- APIPermissionInfo::kFlagMustBeOptional, 0, PermissionMessage::kNone,

+ APIPermissionInfo::kFlagNone, 0, PermissionMessage::kNone,

&CreateAPIPermission<UsbDevicePermission> },

{ APIPermission::kSystemIndicator, "systemIndicator",

APIPermissionInfo::kFlagNone,