Issue 13947050: Stop forcing optional permission on usbDevices section

Issue 13947050: Stop forcing optional permission on usbDevices section (Closed)

Created:
7 years, 8 months ago by Bei Zhang

Modified:
7 years, 7 months ago

Reviewers:
miket_OOO, Bei Zhang

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, zel, gregsimon

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Stop forcing optional permission on usbDevices section BUG=230687 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202176

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -81 lines)			Patch
M	chrome/common/extensions/docs/templates/articles/app_hardware.html	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/common/extensions/permissions/api_permission.h	View	1	2 chunks	+1 line, -10 lines	0 comments	Download
M	chrome/common/extensions/permissions/chrome_api_permissions.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/permissions_data.cc	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/common/extensions/permissions/permissions_data_unittest.cc	View	1	1 chunk	+0 lines, -28 lines	0 comments	Download
D	chrome/test/data/extensions/optional_only_permission/manifest1.json	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
D	chrome/test/data/extensions/optional_only_permission/manifest2.json	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download

Total messages: 8 (0 generated)

Bei Zhang

Hi Sriram, As discussed, this will stop forcing optional permission on usbDevices section in manifest ...

7 years, 8 months ago (2013-04-25 01:17:04 UTC) #1

Bei Zhang

Hi Mike, I mistakenly assigned these two code reviews to Sriram. I'm reassigning it to ...

7 years, 7 months ago (2013-05-02 03:51:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/13947050/1

7 years, 7 months ago (2013-05-22 23:43:06 UTC) #4

miket_OOO

On 2013/05/23 17:09:53, Bei Zhang wrote: > Non trivial changes. Please review. Much smaller code! ...

7 years, 7 months ago (2013-05-24 16:40:38 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ikarienator@chromium.org/13947050/20001

7 years, 7 months ago (2013-05-24 17:32:59 UTC) #7

Message was sent while issue was closed.

Change committed as 202176