Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13945011: Add more conditions where test_isolation_mode defaults to noop. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 8 months ago
Reviewers:
csharp
CC:
chromium-reviews
Base URL:
https://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add more conditions where test_isolation_mode defaults to noop. We know these configurations are broken so there is no point in implying they are supported. R=csharp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193268

Patch Set 1 #

Patch Set 2 : fix because disable_nacl can't be used #

Patch Set 3 : Use almost no conditions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M build/common.gypi View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
M-A Ruel
7 years, 8 months ago (2013-04-09 17:36:59 UTC) #1
csharp
lgtm
7 years, 8 months ago (2013-04-09 17:39:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13945011/1
7 years, 8 months ago (2013-04-09 17:43:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=41835
7 years, 8 months ago (2013-04-09 17:51:04 UTC) #4
M-A Ruel
On 2013/04/09 17:39:50, csharp wrote: > lgtm I reduced the number of conditions checked because ...
7 years, 8 months ago (2013-04-09 20:36:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13945011/13003
7 years, 8 months ago (2013-04-09 20:37:01 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101354
7 years, 8 months ago (2013-04-09 22:43:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/13945011/13003
7 years, 8 months ago (2013-04-09 23:38:45 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 00:17:03 UTC) #9
Message was sent while issue was closed. 
Change committed as 193268

Powered by Google App Engine
This is Rietveld 408576698