Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Unified Diff: build/common.gypi

Issue 13945011: Add more conditions where test_isolation_mode defaults to noop. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Use almost no conditions Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 0fe8b73a27892551156cd5ee253a5398b17a5165..d39128b1e23488a54a4aa840dd5caf5af1b20df6 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -624,12 +624,17 @@
}],
# Whether tests targets should be run, archived or just have the
- # dependencies verified. All the tests targets have the '_run' suffix,
+ # dependencies verified. All the tests targets have the '_run' suffix,
# e.g. base_unittests_run runs the target base_unittests. The test
# target always calls tools/swarm_client/isolate.py. See the script's
# --help for more information and the valid --mode values. Meant to be
# overriden with GYP_DEFINES.
- ['inside_chromium_build==1 and OS != "ios" and OS != "android"', {
+ # TODO(maruel): Remove the conditions as more configurations are
+ # supported.
+ # NOTE: The check for disable_nacl==0 and component=="static_library"
+ # can't be used here because these variables are not defined yet, but it
+ # is still not supported.
+ ['inside_chromium_build==1 and OS!="ios" and OS!="android" and chromeos==0', {
'test_isolation_mode%': 'check',
}, {
'test_isolation_mode%': 'noop',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698