Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13928024: Missing ifdef for Autocheckout bubble causes crash on non-views platforms (Closed)

Created:
7 years, 8 months ago by ahutter
Modified:
7 years, 8 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Missing ifdef for Autocheckout bubble causes crash on non-views platforms BUG=229590 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193429

Patch Set 1 #

Patch Set 2 : Need to call bubble callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ahutter
Ilya, PTAL. Thanks.
7 years, 8 months ago (2013-04-09 20:58:20 UTC) #1
Ilya Sherman
LGTM
7 years, 8 months ago (2013-04-09 21:00:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahutter@chromium.org/13928024/1
7 years, 8 months ago (2013-04-09 21:01:19 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=132813
7 years, 8 months ago (2013-04-09 22:38:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahutter@chromium.org/13928024/1
7 years, 8 months ago (2013-04-09 22:40:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahutter@chromium.org/13928024/12001
7 years, 8 months ago (2013-04-10 00:18:25 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=132912
7 years, 8 months ago (2013-04-10 01:24:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahutter@chromium.org/13928024/12001
7 years, 8 months ago (2013-04-10 16:42:50 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 19:22:45 UTC) #9
Message was sent while issue was closed. 
Change committed as 193429

Powered by Google App Engine
This is Rietveld 408576698