Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7733)

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 13928024: Missing ifdef for Autocheckout bubble causes crash on non-views platforms (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Need to call bubble callback Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
index 80d6c1353d72cbc9eb23258f66b054f66d67b0bd..43804d663c3577147524d66f4ec7a8654e29eda2 100644
--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
@@ -137,6 +137,10 @@ void TabAutofillManagerDelegate::ShowAutocheckoutBubble(
const gfx::RectF& bounding_box,
const gfx::NativeView& native_view,
const base::Callback<void(bool)>& callback) {
+#if !defined(TOOLKIT_VIEWS)
+ callback.Run(false);
+ NOTIMPLEMENTED();
+#else
HideAutocheckoutBubble();
autocheckout_bubble_ =
AutocheckoutBubble::Create(scoped_ptr<AutocheckoutBubbleController>(
@@ -144,6 +148,7 @@ void TabAutofillManagerDelegate::ShowAutocheckoutBubble(
native_view,
callback)));
autocheckout_bubble_->ShowBubble();
+#endif // #if !defined(TOOLKIT_VIEWS)
}
void TabAutofillManagerDelegate::HideAutocheckoutBubble() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698