Subzero: Consider all instruction variables for register preference.

src/IceInstARM32.h

Index: src/IceInstARM32.h
diff --git a/src/IceInstARM32.h b/src/IceInstARM32.h
index ffc3be878426281ed0ba29daa782925e8c6e67fa..60b24844a68ec113f1f809375482a5cc424e6158 100644
--- a/src/IceInstARM32.h
+++ b/src/IceInstARM32.h
@@ -1152,7 +1152,7 @@ public:
     return !isMultiDest() && !isMultiSource() &&
            checkForRedundantAssign(getDest(), getSrc(0));
   }
-  bool isSimpleAssign() const override { return true; }
+  bool isVarAssign() const override { return llvm::isa<Variable>(getSrc(0)); }

[John, 2015/10/12 15:35:16]

this method is inline, but the other is not. does it matter?

[Jim Stichnoth, 2015/10/12 17:27:31]

The implementation of InstAssign::isVarAssign() had to be moved into the .cpp
file, instead of being inline, because the Variable class definition wasn't yet
available.

That turns out not to be the case in these IceInst*.h files, so I'll keep it
inline until it breaks...

   void emit(const Cfg *Func) const override;
   void emitIAS(const Cfg *Func) const override;
   void dump(const Cfg *Func) const override;