Subzero: Consider all instruction variables for register preference.

src/IceInstX86Base.h

Index: src/IceInstX86Base.h
diff --git a/src/IceInstX86Base.h b/src/IceInstX86Base.h
index 36b34ac9e22dce3d476c5cd7d9076680e2f5c20a..f93ac2bbcb1c82b29de409a42299185a8473272c 100644
--- a/src/IceInstX86Base.h
+++ b/src/IceInstX86Base.h
@@ -977,7 +977,9 @@ public:
   bool isRedundantAssign() const override {
     return checkForRedundantAssign(this->getDest(), this->getSrc(0));
   }
-  bool isSimpleAssign() const override { return true; }
+  bool isVarAssign() const override {

[John, 2015/10/12 15:35:16]

the previous (inline) method is defined in a single line, this one isn't. does
it matter?

[Jim Stichnoth, 2015/10/12 17:27:31]

(same answer as before)

+    return llvm::isa<Variable>(this->getSrc(0));
+  }
   void dump(const Cfg *Func) const override {
     if (!BuildDefs::dump())
       return;