third_party/WebKit/Source/wtf/text/StringBuilder.cpp - Issue 1391153004: Make StringImpl's content immutable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringBuilder.cpp

Issue 1391153004: Make StringImpl's content immutable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bug fix: StringBuffer::release returns m_data directly Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringBuilder.cpp

diff --git a/third_party/WebKit/Source/wtf/text/StringBuilder.cpp b/third_party/WebKit/Source/wtf/text/StringBuilder.cpp

index f3a40bc3a4034c8a84f6452ff521bac0326ac028..c4c831a35853d6918c113193c2fdee27e5566416 100644

--- a/third_party/WebKit/Source/wtf/text/StringBuilder.cpp

+++ b/third_party/WebKit/Source/wtf/text/StringBuilder.cpp

@@ -57,12 +57,6 @@ void StringBuilder::reifyString()

return;

}

- if (m_buffer->hasOneRef()) {

- m_buffer->truncateAssumingIsolated(m_length);

- m_string = m_buffer.release();

- return;

- }

m_string = m_buffer->substring(0, m_length);

}