third_party/WebKit/Source/wtf/text/StringBuffer.h - Issue 1391153004: Make StringImpl's content immutable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringBuffer.h

Issue 1391153004: Make StringImpl's content immutable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bug fix: StringBuffer::release returns m_data directly Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringBuffer.h

diff --git a/third_party/WebKit/Source/wtf/text/StringBuffer.h b/third_party/WebKit/Source/wtf/text/StringBuffer.h

index 5e780e63d8090594318186c60f3d38fd1bacda0e..f38e0cf3b74bce9f400574e87fe36f8be01f557d 100644

--- a/third_party/WebKit/Source/wtf/text/StringBuffer.h

+++ b/third_party/WebKit/Source/wtf/text/StringBuffer.h

@@ -70,7 +70,7 @@ void StringBuffer<CharType>::shrink(unsigned newLength)

ASSERT(m_data);

if (m_data->length() == newLength)

return;

- m_data->truncateAssumingIsolated(newLength);

+ m_data = m_data->substring(0, newLength);

}

} // namespace WTF