Use blitframebuffer to implement copySurface.

Use blitframebuffer to implement copySurface.

Committed: http://code.google.com/p/skia/source/detail?r=8633

[robertphillips, 2013-04-11 19:44:10]

lgtm

https://codereview.chromium.org/13910009/diff/6/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/13910009/diff/6/src/gpu/gl/GrGpuGL.cpp#newcod...
src/gpu/gl/GrGpuGL.cpp:2239: if (this->isConfigRenderable(dst->config()) &&
this->isConfigRenderable(src->config()) &&
Does it make sense to wrap this in something like blitFramebufferSupported?

https://codereview.chromium.org/13910009/diff/6/src/gpu/gl/GrGpuGL.cpp#newcod...
src/gpu/gl/GrGpuGL.cpp:2312: if (GrGLCaps::kDesktopEXT_MSFBOType ==
this->glCaps().msFBOType()) {
In this ...?

[bsalomon, 2013-04-11 20:06:57]

https://codereview.chromium.org/13910009/diff/6/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/13910009/diff/6/src/gpu/gl/GrGpuGL.cpp#newcod...
src/gpu/gl/GrGpuGL.cpp:2239: if (this->isConfigRenderable(dst->config()) &&
this->isConfigRenderable(src->config()) &&
On 2013/04/11 19:44:10, robertphillips wrote:
> Does it make sense to wrap this in something like blitFramebufferSupported?

Done.

https://codereview.chromium.org/13910009/diff/6/src/gpu/gl/GrGpuGL.cpp#newcod...
src/gpu/gl/GrGpuGL.cpp:2312: if (GrGLCaps::kDesktopEXT_MSFBOType ==
this->glCaps().msFBOType()) {
On 2013/04/11 19:44:10, robertphillips wrote:
> In this ...?

// The EXT version applies the scissor during the blit, so disable it.

[commit-bot: I haz the power, 2013-04-11 20:23:58]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/13910009/13001

[commit-bot: I haz the power, 2013-04-11 22:00:28]

Change committed as 8633