Issue 13896004: Cleanup various bits of BrowserThreadImpl and PluginServiceImpl.

Issue 13896004: Cleanup various bits of BrowserThreadImpl and PluginServiceImpl. (Closed)

Created:
7 years, 8 months ago by Lei Zhang

Modified:
7 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cleanup various bits of BrowserThreadImpl and PluginServiceImpl. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195957

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -15 lines)			Patch
M	content/browser/browser_child_process_host_impl.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/browser_thread_impl.cc	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
M	content/browser/plugin_service_impl.cc	View	1	2 chunks	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

jam

https://codereview.chromium.org/13896004/diff/1/content/browser/browser_thread_impl.cc File content/browser/browser_thread_impl.cc (right): https://codereview.chromium.org/13896004/diff/1/content/browser/browser_thread_impl.cc#newcode275 content/browser/browser_thread_impl.cc:275: return message_loop != NULL; why?

7 years, 8 months ago (2013-04-18 16:14:40 UTC) #2

Lei Zhang

On 2013/04/18 16:14:40, jam wrote: > https://codereview.chromium.org/13896004/diff/1/content/browser/browser_thread_impl.cc > File content/browser/browser_thread_impl.cc (right): > > https://codereview.chromium.org/13896004/diff/1/content/browser/browser_thread_impl.cc#newcode275 > ...

7 years, 8 months ago (2013-04-18 20:11:15 UTC) #3

jam

On 2013/04/18 20:11:15, Lei Zhang wrote: > On 2013/04/18 16:14:40, jam wrote: > > > ...

7 years, 8 months ago (2013-04-19 16:51:28 UTC) #4

Lei Zhang

On 2013/04/19 16:51:28, jam wrote: > hmm, i think that's personal preference, but there's nothing ...

7 years, 8 months ago (2013-04-19 22:10:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/13896004/6001

7 years, 8 months ago (2013-04-22 17:56:50 UTC) #7

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 8 months ago (2013-04-22 17:58:47 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/13896004/6001

7 years, 8 months ago (2013-04-23 22:26:53 UTC) #9

Message was sent while issue was closed.

Change committed as 195957

Expand Messages | Collapse Messages