Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: content/browser/browser_child_process_host_impl.cc

Issue 13896004: Cleanup various bits of BrowserThreadImpl and PluginServiceImpl. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/browser_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_child_process_host_impl.cc
===================================================================
--- content/browser/browser_child_process_host_impl.cc (revision 194997)
+++ content/browser/browser_child_process_host_impl.cc (working copy)
@@ -300,7 +300,8 @@
}
void BrowserChildProcessHostImpl::OnProcessLaunched() {
- if (!child_process_->GetHandle()) {
+ base::ProcessHandle handle = child_process_->GetHandle();
+ if (!handle) {
delete delegate_; // Will delete us
return;
}
@@ -312,12 +313,12 @@
// IPC channel thereafter.
DCHECK(!early_exit_watcher_.GetWatchedEvent());
early_exit_watcher_.StartWatching(
- new base::WaitableEvent(child_process_->GetHandle()),
+ new base::WaitableEvent(handle),
base::Bind(&BrowserChildProcessHostImpl::OnProcessExitedEarly,
base::Unretained(this)));
#endif
- data_.handle = child_process_->GetHandle();
+ data_.handle = handle;
delegate_->OnProcessLaunched();
}
« no previous file with comments | « no previous file | content/browser/browser_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698