tests_lit/llvm2ice_tests/prune_unreachable.ll - Issue 1387963002: Make sure that all globals are internal, except for "start" functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/llvm2ice_tests/prune_unreachable.ll

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix nit. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests_lit/llvm2ice_tests/nacl-mem-intrinsics.ll ('K') | « tests_lit/llvm2ice_tests/phi_invalid.test ('k') | tests_lit/llvm2ice_tests/randomize-pool-immediate-basic.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests_lit/llvm2ice_tests/prune_unreachable.ll

diff --git a/tests_lit/llvm2ice_tests/prune_unreachable.ll b/tests_lit/llvm2ice_tests/prune_unreachable.ll

index 0c77acd1a8dfeb41332fe33505cd52bfe5f321f5..7ce93e96d964f8faedcfb0e2be0469af2bed5519 100644

--- a/tests_lit/llvm2ice_tests/prune_unreachable.ll

+++ b/tests_lit/llvm2ice_tests/prune_unreachable.ll

@@ -1,12 +1,14 @@

; This tests that unreachable basic blocks are pruned from the CFG, so that

; liveness analysis doesn't detect inconsistencies.

-; RUN: %p2i -i %s --filetype=obj --disassemble --args -Om1 | FileCheck %s

-; RUN: %p2i -i %s --filetype=obj --disassemble --args -O2 | FileCheck %s

+; RUN: %p2i -i %s --filetype=obj --disassemble --args -Om1 \

+; RUN: -allow-externally-defined-symbols | FileCheck %s

+; RUN: %p2i -i %s --filetype=obj --disassemble --args -O2 \

+; RUN: -allow-externally-defined-symbols | FileCheck %s

declare void @abort()

-define i32 @unreachable_block() {

+define internal i32 @unreachable_block() {

entry:

; ret_val has no reaching uses and so its assignment may be

; dead-code eliminated.